Created on 2008-08-26 02:30 by brodie, last changed 2009-06-04 19:00 by georg.brandl. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| traceback-caret.patch | brodie, 2008-08-26 02:30 | |||
| Messages (4) | |||
|---|---|---|---|
| msg71967 - (view) | Author: Brodie Rao (brodie) | Date: 2008-08-26 02:30 | |
>> +
File "<stdin>", line 1
+
^
SyntaxError: invalid syntax
>>> import sys
>>> import traceback
>>> traceback.print_exception(sys.last_type, sys.last_value, None)
File "<stdin>", line 1
+
^
SyntaxError: invalid syntax
>>> sys.last_value
SyntaxError('invalid syntax', ('<stdin>', 1, 2, '+\n'))
print_error_text() effectively ignores trailing newlines when placing
the caret, while traceback.format_exception_only() does not. For certain
syntax errors the offset reported is sometimes at the newline, as in the
case of a line of code that ends just with a plus sign (and in other
similar cases).
I'm attaching a patch for trunk that fixes this issue. I know it also
affects Python 2.5, and I'm sure it affects versions prior. I don't know
about Python 3.0.
|
|||
| msg88870 - (view) | Author: Georg Brandl (georg.brandl) *  |
Date: 2009-06-04 09:15 | |
Thanks, committed as r73206. |
|||
| msg88884 - (view) | Author: Jean-Paul Calderone (exarkun) * |
Date: 2009-06-04 12:18 | |
Any plans for a unit test for this change? |
|||
| msg88893 - (view) | Author: Georg Brandl (georg.brandl) * |
Date: 2009-06-04 19:00 | |
Good point. Added a test in r73232. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2009-06-04 19:00:13 | georg.brandl | set | messages: + msg88893 |
| 2009-06-04 12:18:09 | exarkun | set | nosy:
+ exarkun messages: + msg88884 |
| 2009-06-04 09:15:25 | georg.brandl | set | status: open -> closed nosy: + georg.brandl messages: + msg88870 resolution: accepted |
| 2008-08-26 02:30:25 | brodie | create | |