This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Cleanup of tp_basicsize inheritance
Type: Stage:
Components: Versions:
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: Nosy List: BreamoreBoy, Rhamphoryncus, benjamin.peterson, nnorwitz
Priority: normal Keywords: patch

Created on 2008-07-03 06:31 by Rhamphoryncus, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
python-inheritsize.diff Rhamphoryncus, 2008-07-03 06:31
Messages (3)
msg69169 - (view) Author: Adam Olsen (Rhamphoryncus) Date: 2008-07-03 06:31
inherit_special contains logic to inherit the base type's tp_basicsize
if the new type doesn't have it set.  The logic was spread over several
lines, but actually does almost nothing (presumably an artifact of
previous versions), so here's a patch to clean it up.

There was also an incorrect comment which I've removed.  A new one
should perhaps be added explaining what the other code there does, but
it's not affected by what I'm changing, and I'm not sure why it's doing
what it's doing anyway, so I'll leave that to someone else.
msg109301 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2010-07-05 05:36
This is a tiny patch against typeobject.c, could somebody please run with it?
msg109322 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2010-07-05 15:01
Thanks. r82577.
History
Date User Action Args
2022-04-11 14:56:36adminsetgithub: 47518
2010-07-05 15:01:39benjamin.petersonsetstatus: open -> closed

nosy: + benjamin.peterson
messages: + msg109322

resolution: accepted
2010-07-05 05:36:44BreamoreBoysetnosy: + BreamoreBoy
messages: + msg109301
2008-07-03 06:31:38Rhamphoryncuscreate