classification
Title: shutil references undefined WindowsError symbol
Type: crash Stage:
Components: Library (Lib) Versions: Python 3.0, Python 2.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: pitrou Nosy List: draghuram, dvitek, pitrou (3)
Priority: high Keywords patch

Created on 2008-06-18 20:49 by dvitek, last changed 2008-08-11 17:21 by pitrou.

Files
File name Uploaded Description Edit Remove
p.patch dvitek, 2008-06-18 20:49 patch for shutil.py
Messages (7)
msg68373 - (view) Author: David Vitek (dvitek) Date: 2008-06-18 20:48 
If copystat fails in copytree on a non-windows box, you will get:

NameError: global name 'WindowsError' is not defined:
...
    except WindowsError:
msg68374 - (view) Author: Raghuram Devarakonda (draghuram) Date: 2008-06-18 20:56 
This is same as #2549 which also reported the same problem. In fact, the
problem was originally found in #1545. As I said there, the proposed
patch has a very small problem. Can you please take a look?
msg68420 - (view) Author: Raghuram Devarakonda (draghuram) Date: 2008-06-19 20:05 
I submitted a patch at http://codereview.appspot.com/2384. Please take a
look.
msg70946 - (view) Author: Antoine Pitrou (pitrou) Date: 2008-08-09 18:05 
Raghuram, your patch looks good to me. I'll try to test it under Windows
soon.
msg71006 - (view) Author: Antoine Pitrou (pitrou) Date: 2008-08-11 09:44 
Patch works under Windows.
msg71020 - (view) Author: Raghuram Devarakonda (draghuram) Date: 2008-08-11 15:46 
> Patch works under Windows.

Thanks. Can you please commit the change?
msg71023 - (view) Author: Antoine Pitrou (pitrou) Date: 2008-08-11 17:21 
Fixed in r65644.
History
Date User Action Args
2008-08-11 17:21:57pitrousetstatus: open -> closed
resolution: fixed
messages: + msg71023
2008-08-11 15:46:37draghuramsetmessages: + msg71020
2008-08-11 09:44:43pitrousetpriority: high
assignee: pitrou
messages: + msg71006
versions: + Python 2.6, Python 3.0, - Python 2.5
2008-08-09 18:05:14pitrousetnosy: + pitrou
messages: + msg70946
2008-06-19 20:05:35draghuramsetmessages: + msg68420
2008-06-18 20:56:59draghuramsetnosy: + draghuram
messages: + msg68374
2008-06-18 20:49:09dvitekcreate