classification
Title: Miscellaneous errors in asyncio speedup module
Type: behavior Stage: patch review
Components: asyncio, Extension Modules Versions: Python 3.7, Python 3.6
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: giampaolo.rodola, haypo, inada.naoki, serhiy.storchaka, yselivanov
Priority: normal Keywords:

Created on 2017-08-11 16:28 by serhiy.storchaka, last changed 2017-08-11 16:51 by serhiy.storchaka.

Pull Requests
URL Status Linked Edit
PR 3076 open serhiy.storchaka, 2017-08-11 16:33
Messages (6)
msg300171 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-08-11 16:28
Proposed patch fixes miscellaneous errors in asyncio speedup module. It is hard to enumerate they all, but they are mostly NULL dereferencing, reference leaks, and handling exceptions in corner cases.
msg300172 - (view) Author: Yury Selivanov (yselivanov) * (Python committer) Date: 2017-08-11 16:33
Adding INADA, he is a co-author/reviewer of that code.
msg300174 - (view) Author: Yury Selivanov (yselivanov) * (Python committer) Date: 2017-08-11 16:36
Huge thanks, Serhiy, btw.
msg300175 - (view) Author: STINNER Victor (haypo) * (Python committer) Date: 2017-08-11 16:38
"reference leaks" oh? our Refleaks buildbots didn't catch them. Do your new tests reproduce the bugs, to make sure that we don't leak anymore?
msg300176 - (view) Author: Yury Selivanov (yselivanov) * (Python committer) Date: 2017-08-11 16:40
> "reference leaks" oh? our Refleaks buildbots didn't catch them.

The test suite for Tasks and Futures is pretty extensive, but it obviously doesn't cover some obscure use cases.

+1 to make sure that any refleak that was discovered should have a new regression test for it.
msg300177 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-08-11 16:51
They are occurred in very obscure cases like calling __init__ multiple times. The patch doesn't contain tests for them.
History
Date User Action Args
2017-08-11 16:51:08serhiy.storchakasetmessages: + msg300177
2017-08-11 16:40:31yselivanovsetmessages: + msg300176
2017-08-11 16:38:23hayposetmessages: + msg300175
2017-08-11 16:36:30yselivanovsetmessages: + msg300174
2017-08-11 16:33:30yselivanovsetnosy: + inada.naoki
messages: + msg300172
2017-08-11 16:33:09serhiy.storchakasetpull_requests: + pull_request3113
2017-08-11 16:28:18serhiy.storchakacreate