This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: test_get_font (idlelib.idle_test.test_config.IdleConfTest) failure on x86 Windows7 3.x
Type: Stage: resolved
Components: IDLE, Tests, Windows Versions: Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: terry.reedy Nosy List: louielu, paul.moore, steve.dower, terry.reedy, tim.golden, vstinner, zach.ware
Priority: normal Keywords: buildbot

Created on 2017-07-19 11:28 by vstinner, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 2753 terry.reedy, 2017-07-19 23:42
PR 2769 merged terry.reedy, 2017-07-20 00:28
PR 5508 merged terry.reedy, 2018-02-03 05:52
Messages (13)
msg298668 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2017-07-19 11:28
The build only contains one change:

commit f776eb0f0e046f2fa3a96540bb42d8cf970f6c55

bpo-30917: IDLE: Add config.IdleConf unittests (#2691) Patch by Louie Lu.

http://buildbot.python.org/all/builders/x86%20Windows7%203.x/builds/893/steps/test/logs/stdio

======================================================================
FAIL: test_get_font (idlelib.idle_test.test_config.IdleConfTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\idlelib\idle_test\test_config.py", line 605, in test_get_font
    (f['family'], 10 if f['size'] < 10 else f['size'], f['weight']))
AssertionError: Tuples differ: ('Courier New', 9, 'normal') != ('Courier New', 10, 'normal')

First differing element 1:
9
10

- ('Courier New', 9, 'normal')
?                 ^

+ ('Courier New', 10, 'normal')
?                 ^^
msg298679 - (view) Author: Louie Lu (louielu) * Date: 2017-07-19 14:21
After checking source code, I found that is my fault on the test code. After the blocker PR 2754 been merged, I'll fix this issue.
msg298695 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-07-19 23:53
I merged pr2754 in pr2753, the 3.6 backport of pr2691.  To avoid breaking 3.6 buildbots more than one test, I will hold off merging pr2753 until a fix is available.
msg298697 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-07-20 00:15
Louie, I am fixing this (I believe).
msg298701 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-07-20 00:45
New changeset 9f9192afbb4e45d09f0d3d717b457d157dc46398 by terryjreedy in branch 'master':
 	bpo-30968: Fix test_get_font in IDLE's test_config.  (#2769)
https://github.com/python/cpython/commit/9f9192afbb4e45d09f0d3d717b457d157dc46398
msg298702 - (view) Author: Louie Lu (louielu) * Date: 2017-07-20 01:16
Yes, Terry's patch fixed this.
msg298706 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-07-20 05:02
Fix worked: test_idle passed in build 897.
http://buildbot.python.org/all/builders/x86%20Windows7%203.x/builds/897/steps/test/logs/stdio
I also included the fix of PR2769 in PR2753 (3.6 backport).
msg298711 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2017-07-20 09:07
Terry: FYI your commit message starts with multiple spaces. I would also suggest you to format your name as you did previously: "Terry Jan Reedy".

commit 9f9192afbb4e45d09f0d3d717b457d157dc46398
Author: terryjreedy <tjreedy@udel.edu>
Date:   Wed Jul 19 20:45:36 2017 -0400

            bpo-30968: Fix test_get_font in IDLE's test_config.  (#2769)
msg298735 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-07-20 17:11
I don't understand 'format your name' as there is no formatting that I did.  Github copies account name and email as they are.

I have no idea about commit message.  The PR title has no extra spaces.  But github does not always copy correctly.
msg298737 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-07-20 17:14
I will try to look at the first line more carefully before hitting the 2nd green button.
msg298741 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2017-07-20 17:27
Terry J. Reedy: I don't understand 'format your name' as there is no formatting that I did.

GitHub picks your commits unchanged. Git picks your name from your .gitconfig configuration file, global $HOME/.gitconfig or local <cpython>/.gitconfig.

It's just that I saw "terryjreedy" in your last commit, instead of the usual "Terry Jan Reedy".

It's up to you to pick whatever name you want, I was just surprised to see the name formatted differently.

> I have no idea about commit message.  The PR title has no extra spaces.  But github does not always copy correctly.

It doesn't matter at all. It's just that I was surprised ;-)
msg298758 - (view) Author: Louie Lu (louielu) * Date: 2017-07-21 02:04
For the problem about the small name in git log Author, if you want to changed it, it will need to setup at https://github.com/settings/profile and update the first column "Name".

I think this is because we merged on GitHub, and GitHub ignores the git author but use GitHub account's name (if this didn't setup, it will fallback to GitHub account). I have some small name with "mlouielu" when I changed to this new account.
msg298759 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-07-21 02:16
Thanks.  I will see what that does.
History
Date User Action Args
2022-04-11 14:58:49adminsetgithub: 75151
2018-02-03 05:52:36terry.reedysetpull_requests: + pull_request5342
2018-02-03 05:25:41terry.reedysetpull_requests: - pull_request5339
2018-02-03 04:36:10terry.reedysetpull_requests: + pull_request5339
2017-07-21 02:16:32terry.reedysetmessages: + msg298759
2017-07-21 02:04:43louielusetmessages: + msg298758
2017-07-20 17:27:23vstinnersetmessages: + msg298741
2017-07-20 17:14:10terry.reedysetmessages: + msg298737
2017-07-20 17:11:31terry.reedysetmessages: + msg298735
2017-07-20 09:07:54vstinnersetmessages: + msg298711
2017-07-20 05:02:15terry.reedysetstatus: open -> closed
resolution: fixed
messages: + msg298706

stage: resolved
2017-07-20 01:16:47louielusetmessages: + msg298702
2017-07-20 00:45:38terry.reedysetmessages: + msg298701
2017-07-20 00:28:54terry.reedysetpull_requests: + pull_request2827
2017-07-20 00:15:52terry.reedysetmessages: + msg298697
2017-07-19 23:53:26terry.reedysetmessages: + msg298695
2017-07-19 23:42:30terry.reedysetpull_requests: + pull_request2826
2017-07-19 14:21:22louielusetmessages: + msg298679
2017-07-19 11:29:51vstinnersetnosy: + terry.reedy, louielu

components: + IDLE
assignee: terry.reedy
2017-07-19 11:29:05vstinnersetkeywords: + buildbot
nosy: + paul.moore, tim.golden, zach.ware, steve.dower

components: + Tests, Windows
versions: + Python 3.7
2017-07-19 11:28:53vstinnercreate