➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2017-06-08 14:59 by vstinner, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 2003 | merged | vstinner, 2017-06-08 15:28 | |
| PR 2008 | merged | vstinner, 2017-06-08 16:20 | |
| Messages (7) | |||
|---|---|---|---|
| msg295445 - (view) | Author: STINNER Victor (vstinner) *  |
Date: 2017-06-08 14:59 | |
http://buildbot.python.org/all/builders/AMD64%20Windows8.1%20Refleaks%203.x/builds/22/steps/test/logs/stdio 0:00:12 [ 7/405/1] test_winconsoleio failed beginning 6 repetitions 123456 ...... test_winconsoleio leaked [43, 43, 43] references, sum=129 |
|||
| msg295446 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2017-06-08 15:17 | |
The following code leaks one reference:
f = _io._WindowsConsoleIO('CONIO$', 'r')
f.close()
f = None
|
|||
| msg295447 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2017-06-08 15:29 | |
With https://github.com/python/cpython/pull/2003 test_winconsoleio doesn't leak anymore. |
|||
| msg295452 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2017-06-08 16:19 | |
New changeset 29adc13bd797d9c9e7fcb893a7c49ce7f7ad388c by Victor Stinner in branch 'master': bpo-30601: Fix a refleak in WindowsConsoleIO (#2003) https://github.com/python/cpython/commit/29adc13bd797d9c9e7fcb893a7c49ce7f7ad388c |
|||
| msg295456 - (view) | Author: Eryk Sun (eryksun) *  |
Date: 2017-06-08 16:49 | |
Segev included a fix for this leak in PR 1927 for bpo30555, but I suppose it's better to fix it separately. |
|||
| msg295465 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2017-06-08 21:13 | |
New changeset 31b950ab86f5c99a18c16dbf1900b854b94e0659 by Victor Stinner in branch '3.6': bpo-30601: Fix a refleak in WindowsConsoleIO (#2003) (#2008) https://github.com/python/cpython/commit/31b950ab86f5c99a18c16dbf1900b854b94e0659 |
|||
| msg295507 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2017-06-09 09:37 | |
Eryk Sun: "Segev included a fix for this leak in PR 1927 for bpo30555, but I suppose it's better to fix it separately." I saw this PR but it changes a lot of code. I didn't notice that it fixes this bug as well. I chose to fix quickly the refleak to be able to detect more easily future refleaks (ie. repair the new refleak windows buildbot! -- "AMD64 Windows8.1 Refleaks 3.6" buildbot confirms that test_winconsoleio doesn't leak anymore! So I close this issue. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:47 | admin | set | github: 74786 |
| 2017-06-09 09:37:55 | vstinner | set | status: open -> closed resolution: fixed messages: + msg295507 stage: resolved |
| 2017-06-08 21:13:14 | vstinner | set | messages: + msg295465 |
| 2017-06-08 16:49:11 | eryksun | set | nosy:
+ eryksun, Segev Finer messages: + msg295456 |
| 2017-06-08 16:20:27 | vstinner | set | pull_requests: + pull_request2074 |
| 2017-06-08 16:19:27 | vstinner | set | messages: + msg295452 |
| 2017-06-08 15:29:01 | vstinner | set | messages: + msg295447 |
| 2017-06-08 15:28:10 | vstinner | set | pull_requests: + pull_request2070 |
| 2017-06-08 15:17:30 | vstinner | set | messages: + msg295446 |
| 2017-06-08 14:59:13 | vstinner | create | |