This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Leak in sys.getwindowsversion
Type: resource usage Stage: resolved
Components: Windows Versions: Python 3.7, Python 3.6, Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: serhiy.storchaka Nosy List: Segev Finer, eryksun, paul.moore, serhiy.storchaka, steve.dower, tim.golden, vstinner, zach.ware
Priority: normal Keywords:

Created on 2017-06-04 17:20 by Segev Finer, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 1940 merged Segev Finer, 2017-06-04 17:23
PR 1970 merged serhiy.storchaka, 2017-06-06 15:59
PR 1971 merged serhiy.storchaka, 2017-06-06 16:00
Messages (6)
msg295132 - (view) Author: Segev Finer (Segev Finer) * Date: 2017-06-04 17:20
There is a ref leak in sys.getwindowsversion due to using PyTuple_Pack and forgetting that it increments the ref count of passed in objects. Found here: https://github.com/python/cpython/pull/1927#issuecomment-306019512.

Clearly shows up in python -m test -R 3:2 test_sys
msg295137 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-06-04 17:52
New changeset 48fb766f70d9ca9d5934cbddbe8d8e7972cb6343 by Serhiy Storchaka (Segev Finer) in branch 'master':
bpo-30567: Fix refleak in sys.getwindowsversion (#1940)
https://github.com/python/cpython/commit/48fb766f70d9ca9d5934cbddbe8d8e7972cb6343
msg295275 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-06-06 16:23
New changeset 68e5af89d46db6250a0fa7fe4249c66f866faff8 by Serhiy Storchaka in branch '3.6':
[3.6] bpo-30567: Fix refleak in sys.getwindowsversion (GH-1940) (#1970)
https://github.com/python/cpython/commit/68e5af89d46db6250a0fa7fe4249c66f866faff8
msg295276 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-06-06 16:23
New changeset 86f8f1f05cd5822b4a4031b90cfdbe5fa1b1159e by Serhiy Storchaka in branch '3.5':
[3.5] bpo-30567: Fix refleak in sys.getwindowsversion (GH-1940) (#1971)
https://github.com/python/cpython/commit/86f8f1f05cd5822b4a4031b90cfdbe5fa1b1159e
msg295277 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-06-06 16:24
Thank you for your patch Segev!
msg295351 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2017-06-07 15:45
The issue 30546 has been marked as a duplicate of this issue.
History
Date User Action Args
2022-04-11 14:58:47adminsetgithub: 74752
2017-06-07 15:45:14vstinnersetnosy: + vstinner
messages: + msg295351
2017-06-07 15:44:44vstinnerlinkissue30546 superseder
2017-06-06 16:24:40serhiy.storchakasetstatus: open -> closed
resolution: fixed
messages: + msg295277

stage: backport needed -> resolved
2017-06-06 16:23:23serhiy.storchakasetmessages: + msg295276
2017-06-06 16:23:04serhiy.storchakasetmessages: + msg295275
2017-06-06 16:00:40serhiy.storchakasetpull_requests: + pull_request2037
2017-06-06 15:59:55serhiy.storchakasetpull_requests: + pull_request2036
2017-06-05 17:33:05brett.cannonsetassignee: serhiy.storchaka
2017-06-04 17:53:34serhiy.storchakasetstage: backport needed
2017-06-04 17:52:30serhiy.storchakasetnosy: + serhiy.storchaka
messages: + msg295137
2017-06-04 17:52:20ned.deilysetnosy: + paul.moore, tim.golden, zach.ware, steve.dower
components: + Windows, - Interpreter Core
2017-06-04 17:23:19Segev Finersetpull_requests: + pull_request2019
2017-06-04 17:23:11Segev Finersetnosy: + eryksun
2017-06-04 17:20:58Segev Finercreate