➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2017-05-01 18:59 by Decorater, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 2808 | closed | Segev Finer, 2017-07-21 22:12 | |
| Messages (6) | |||
|---|---|---|---|
| msg292694 - (view) | Author: Decorater (Decorater) * | Date: 2017-05-01 18:59 | |
Basically running make_zip like this: ".\PCbuild\amd64\python.exe" ".\Tools\msi\make_zip.py" -a x64 -o ".\python36-x86-x64" Cuases make_zip mess up where none of the libs\*.lib, nor any of the assemblies are copied. And is reproducible on me. However doing something like this on the 32 bit version of python does not get this issue. |
|||
| msg298825 - (view) | Author: Segev Finer (Segev Finer) * | Date: 2017-07-21 22:02 | |
Try with:
.\python.bat Tools\msi\make_zip.py -a amd64 -o py37-amd64.zip
It requires amd64 instead of x64. Probably can add a choices (https://docs.python.org/3/library/argparse.html#choices) argument there to make it more robust.
|
|||
| msg298851 - (view) | Author: Steve Dower (steve.dower) *  |
Date: 2017-07-22 14:10 | |
I have a separate PR out that fixes this one, just waiting on Zach to review (but since it only touches the more obscure release files, it's rare for anyone but me to have an opinion). The script is supposed to take the build path rather than the architecture, but that got reverted at some point. |
|||
| msg298854 - (view) | Author: Segev Finer (Segev Finer) * | Date: 2017-07-22 14:31 | |
I did make a PR which only changes -a/--arch to a choices argument. https://github.com/python/cpython/pull/2808 I guess the PR you are talking about is https://github.com/python/cpython/pull/2750/files which changes this entirely. |
|||
| msg298885 - (view) | Author: Steve Dower (steve.dower) * |
Date: 2017-07-23 03:13 | |
That's the PR I meant (on phone today, so navigating gh is out). If you look through history you'll see it's mostly a revert of a revert, at least for that script. |
|||
| msg299327 - (view) | Author: Segev Finer (Segev Finer) * | Date: 2017-07-27 17:18 | |
Since PR 2750 is merged, I think this can be closed. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:45 | admin | set | github: 74408 |
| 2017-07-27 18:21:21 | steve.dower | set | status: open -> closed resolution: not a bug stage: resolved |
| 2017-07-27 17:18:35 | Segev Finer | set | messages: + msg299327 |
| 2017-07-23 03:13:55 | steve.dower | set | messages: + msg298885 |
| 2017-07-22 14:31:22 | Segev Finer | set | messages: + msg298854 |
| 2017-07-22 14:10:59 | steve.dower | set | messages: + msg298851 |
| 2017-07-21 22:12:18 | Segev Finer | set | pull_requests: + pull_request2859 |
| 2017-07-21 22:02:42 | Segev Finer | set | nosy:
+ Segev Finer messages: + msg298825 |
| 2017-05-01 18:59:18 | Decorater | create | |