➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2017-04-26 15:50 by JelleZijlstra, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 1301 | merged | JelleZijlstra, 2017-04-26 15:50 | |
| Messages (6) | |||
|---|---|---|---|
| msg292364 - (view) | Author: Jelle Zijlstra (JelleZijlstra) *  |
Date: 2017-04-26 15:50 | |
The bytes1 ArgumentDescriptor is duplicated in pickletools.py. |
|||
| msg292366 - (view) | Author: Tim Peters (tim.peters) * |
Date: 2017-04-26 15:54 | |
I already commented on github - +1 for this change. |
|||
| msg292367 - (view) | Author: Mariatta (Mariatta) * |
Date: 2017-04-26 16:15 | |
Does this need to be backported? |
|||
| msg292370 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2017-04-26 16:32 | |
The variant without " in the string" is more correct and consistent with bytes4 and bytes8. The first bytes1 was added in issue16550. The duplicate was mistakenly added in issue17810. This change can be backported, but it is not worth since the duplication doesn't have any effect. |
|||
| msg292457 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2017-04-27 16:05 | |
New changeset 5a4e3d8f9c37e700402b23fafbfc413e5ca3113d by Serhiy Storchaka (Jelle Zijlstra) in branch 'master': bpo-30174: Remove duplicate definition from pickletools (#1301) https://github.com/python/cpython/commit/5a4e3d8f9c37e700402b23fafbfc413e5ca3113d |
|||
| msg292459 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2017-04-27 16:07 | |
Thank you for catching this Jelle! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:45 | admin | set | github: 74360 |
| 2017-04-27 16:07:12 | serhiy.storchaka | set | status: open -> closed resolution: fixed messages: + msg292459 stage: patch review -> resolved |
| 2017-04-27 16:05:29 | serhiy.storchaka | set | messages: + msg292457 |
| 2017-04-26 16:32:47 | serhiy.storchaka | set | nosy:
+ pitrou, serhiy.storchaka messages: + msg292370 components: + Library (Lib) type: behavior |
| 2017-04-26 16:15:20 | Mariatta | set | versions:
+ Python 3.7 nosy: + Mariatta messages: + msg292367 stage: patch review |
| 2017-04-26 15:54:11 | tim.peters | set | nosy:
+ tim.peters messages: + msg292366 |
| 2017-04-26 15:50:03 | JelleZijlstra | create | |