This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Add tests for header API of 'urllib.request.Request' class
Type: enhancement Stage: resolved
Components: Tests Versions: Python 3.7
process
Status: closed Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: iritkatriel, jaysinh.shukla, martin.panter
Priority: normal Keywords:

Created on 2017-03-12 12:49 by jaysinh.shukla, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 643 closed jaysinh.shukla, 2017-03-12 12:54
Messages (3)
msg289515 - (view) Author: Martin Panter (martin.panter) * (Python committer) Date: 2017-03-12 22:32
I think the RequestTests class really belongs in test_urllib2, which already has a RequestHdrsTests class testing these APIs.

BTW test_urllib.py (no 2) is mainly for testing the stuff that came from Python 2’s “urllib” module, but the Request class is in “urllib2” instead.
msg391230 - (view) Author: Irit Katriel (iritkatriel) * (Python committer) Date: 2021-04-16 17:01
Jaysinh, I see you closed the PR. Did you intend to close this issue as well or are you still planning to work on this?
msg395846 - (view) Author: Irit Katriel (iritkatriel) * (Python committer) Date: 2021-06-14 20:09
Closing as this seems abandoned. Please reopen or create a new issue if you would like to continue working on it.
History
Date User Action Args
2022-04-11 14:58:44adminsetgithub: 73985
2021-06-14 20:09:10iritkatrielsetstatus: pending -> closed

messages: + msg395846
stage: resolved
2021-04-16 17:01:31iritkatrielsetstatus: open -> pending
nosy: + iritkatriel
messages: + msg391230

2017-03-12 22:32:47martin.pantersetnosy: + martin.panter
messages: + msg289515
2017-03-12 12:54:42jaysinh.shuklasetpull_requests: + pull_request532
2017-03-12 12:49:16jaysinh.shuklacreate