Created on 2008-05-22 14:34 by htgoebel, last changed 2012-02-26 03:12 by merwok. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| simple-0.0.0.0.1.tar.gz | htgoebel, 2008-05-22 14:34 | simple package to show the bug | ||
| bdist_rpm.patch | crobben, 2011-10-06 22:13 | bdist_rpm patch | review | |
| test_bdist_rpm.patch | crobben, 2011-10-10 09:39 | patch for test_bdist_rpm.py | review | |
| bdist_rpm-2.7.patch | crobben, 2011-10-10 09:42 | review | ||
| Messages (13) | |||
|---|---|---|---|
| msg67192 - (view) | Author: Hartmut Goebel (htgoebel) | Date: 2008-05-22 14:34 | |
In Python 2.5 distutils has a bug in bdist_rpm: Generated distribution files are not listed in ``distribution.dist_files``. Thus .rpms can not be handled by other tools, eg. ``upload``. I need this bug fixed for automated upload of files using <http://origo-submit.origo.ethz.ch>. Enclosed please find a simple package to show the bug. Just run python setup.py bdist_rpm and watch the (missing) output. In contrast see the output of python setup.py sdist Additionally: While untested, this should effect distutils ``upload`` command. RPMs are not in the dist_files list and when looking at the source, there seams to be no 'trick' to add them later. |
|||
| msg112432 - (view) | Author: Éric Araujo (merwok) *  |
Date: 2010-08-02 08:59 | |
Tarek, can this bug be fixed or is it outdated? IOW, is bdist_rpm officially discouraged or do you still accept bugfixes for it? |
|||
| msg143221 - (view) | Author: Éric Araujo (merwok) * |
Date: 2011-08-30 15:24 | |
Even thought bdist_rpm is gone from distutils2, this is a bug that can be fixed in distutils. Adding the easy keyword to let potential contributors find this bug; hint: look at how bdist_dumb registers distributions with dist.dist_files. |
|||
| msg145045 - (view) | Author: Carl Robben (crobben) | Date: 2011-10-06 22:13 | |
I found that bdist_rpm wasn't registering distributions with dist.dist_files at all. The attached patch should be all that's needed to fix this. |
|||
| msg145092 - (view) | Author: Éric Araujo (merwok) * |
Date: 2011-10-07 16:03 | |
Great! Could you add a test for this? By the way, do you have a machine with rpm installed? I don’t, so I won’t be able to test the patch. |
|||
| msg145292 - (view) | Author: Carl Robben (crobben) | Date: 2011-10-10 09:39 | |
Here's a patch for test_bdist_rpm.py and to check the contents of dist.dist_files |
|||
| msg145293 - (view) | Author: Carl Robben (crobben) | Date: 2011-10-10 09:42 | |
Adding a patch for 2.7 |
|||
| msg145305 - (view) | Author: Éric Araujo (merwok) * |
Date: 2011-10-10 15:41 | |
Looks good. Do you have rpm on your machine? If yes, have you run the tests successfully? |
|||
| msg145333 - (view) | Author: Carl Robben (crobben) | Date: 2011-10-11 06:28 | |
Yeah I installed rpm and have run the tests successfully. |
|||
| msg152516 - (view) | Author: Éric Araujo (merwok) * |
Date: 2012-02-03 14:16 | |
FYI I have committed the patch to my repo and will push as soon as I can. |
|||
| msg152685 - (view) | Author: Roundup Robot (python-dev) | Date: 2012-02-05 12:50 | |
New changeset 26aea1825418 by Éric Araujo in branch '3.2': Stop ignoring RPMs in distutils' upload command (#2945). http://hg.python.org/cpython/rev/26aea1825418 New changeset 1cb9b8126534 by Éric Araujo in branch 'default': Merge edits from 3.2 (#13716, #1040439, #2945, #13770, #6715) http://hg.python.org/cpython/rev/1cb9b8126534 |
|||
| msg154296 - (view) | Author: Roundup Robot (python-dev) | Date: 2012-02-26 02:49 | |
New changeset f606d722ca23 by Éric Araujo in branch '2.7': Stop ignoring RPMs in distutils' upload command (#2945). http://hg.python.org/cpython/rev/f606d722ca23 |
|||
| msg154305 - (view) | Author: Éric Araujo (merwok) * |
Date: 2012-02-26 03:12 | |
Fixed in 2.7 too, thanks to you both. If you have the time to run the tests, it would be great to get a confirmation (I’m not sure we have a buildbot with rpm installed for 2.7). |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2012-02-26 03:12:53 | merwok | set | status: open -> closed resolution: fixed messages: + msg154305 stage: patch review -> resolved |
| 2012-02-26 02:49:07 | python-dev | set | messages: + msg154296 |
| 2012-02-05 12:50:13 | python-dev | set | nosy:
+ python-dev messages: + msg152685 |
| 2012-02-03 14:16:22 | merwok | set | assignee: tarek -> merwok messages: + msg152516 |
| 2011-10-11 06:28:48 | crobben | set | messages: + msg145333 |
| 2011-10-10 15:41:42 | merwok | set | messages:
+ msg145305 stage: needs patch -> patch review |
| 2011-10-10 09:42:10 | crobben | set | files:
+ bdist_rpm-2.7.patch messages: + msg145293 |
| 2011-10-10 09:39:47 | crobben | set | files:
+ test_bdist_rpm.patch messages: + msg145292 |
| 2011-10-07 16:03:17 | merwok | set | messages: + msg145092 |
| 2011-10-06 22:13:33 | crobben | set | files:
+ bdist_rpm.patch nosy: + crobben messages: + msg145045 keywords: + patch |
| 2011-08-30 15:24:21 | merwok | set | keywords:
+ easy stage: needs patch messages: + msg143221 versions: + Python 3.3, - Python 3.1 |
| 2010-08-02 08:59:35 | merwok | set | nosy:
+ merwok messages: + msg112432 versions: + Python 3.2 |
| 2009-02-06 09:15:16 | tarek | set | assignee: tarek nosy: + tarek versions: + Python 3.1, Python 2.7, - Python 2.5 |
| 2008-05-22 14:34:59 | htgoebel | set | type: behavior |
| 2008-05-22 14:34:30 | htgoebel | create | |