This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: IDLE search and replace should use 'hit' tag instead of 'hilite'
Type: enhancement Stage:
Components: IDLE Versions: Python 3.10
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: terry.reedy Nosy List: d s2, terry.reedy
Priority: normal Keywords:

Created on 2017-01-28 01:03 by d s2, last changed 2022-04-11 14:58 by admin.

Messages (3)
msg286393 - (view) Author: d s (d s2) Date: 2017-01-28 01:03
Searching for this issue turned up a bunch of results claiming it's fixed, but it isn't, at least not on my windows 10 machine. I tried replacing 'hit' with 'itdunwork' in colorizer.py, searchbase.py, replace.py, searchengine.py, config.py, search.py, configdialog.py, and of course config-highlight.cfg, but it didn't work.
msg286395 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-01-28 03:20
The now-closed issues I remember were about hits not being visibly marked at all.  For me, on Win 10 with 3.6, they are being marked.  If you are referring to any discussion specifically about which tag to use, please post the issue numbers prefixed with '#', as in #29382, to make them become links.

Without a patch and more explanaton, I am not sure what you did and what you saw as a result.

I have considered changing the 'hit' tag, but I want to first investigate the behave of other editors (and apps with 'find' functions) on the major platforms.  When I have a proposed patch, I will solicit opinions on whether it is better.
msg286397 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-01-28 03:45
After the original bug for #18590 was fixed, I left it open for working on the tags.  (Currently, Find and the find part of Replace work differently and at least one of them double tags found text.)  I decided to close it and use this for the tag choice issue.

My replace_find_hit.diff patch on #18590 should be considered transferred to this one.
History
Date User Action Args
2022-04-11 14:58:42adminsetgithub: 73568
2020-06-06 22:09:25terry.reedysetversions: + Python 3.10, - Python 3.6, Python 3.7
2017-01-28 03:45:25terry.reedysetmessages: + msg286397
2017-01-28 03:38:53terry.reedylinkissue18590 superseder
2017-01-28 03:20:46terry.reedysettype: behavior -> enhancement
title: IDLE search/replace/replace+find is (still?) using the 'hilite' tag instead of 'hit' -> IDLE search and replace should use 'hit' tag instead of 'hilite'
components: - Windows

nosy: - paul.moore, tim.golden, zach.ware, steve.dower
versions: + Python 3.7, - Python 3.5
messages: + msg286395
2017-01-28 01:03:15d s2create