➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2017-01-13 15:06 by Dave Jones, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| missing_venv_common.diff | Dave Jones, 2017-01-13 15:06 | Include venv/scripts/common in LIBSUBDIRS | review | |
| Messages (3) | |||
|---|---|---|---|
| msg285403 - (view) | Author: Dave Jones (Dave Jones) * | Date: 2017-01-13 15:06 | |
While attempting to diagnose something (unrelated to this issue) under python 3.6, I used the following steps to clone and build a non-root python installation:
$ mkdir py36
$ hg clone https://hg.python.org/cpython
$ cd cpython
$ hg update 3.6
$ ./configure --prefix=/home/pi/py36
$ make
$ make install
Afterwards I attempted to set up a venv for further testing:
$ /home/pi/py36/bin/python3 -m venv py36env
This succeeded but, unfortunately, activating the venv proved impossible as the "activate" script was missing from its "bin" sub-dir.
After a bit of investigation it appears that "make install" had copied "Lib/venv/scripts/posix" but not "Lib/venv/scripts/common" into the installation, hence the templates for "activate.csh" and "activate.fish" are present, but not the "activate" template.
I had a search around for related issues but only found #22343 which explains why "activate" is no longer present (because it's moved from scripts/posix/ to scripts/common/) but I don't think is responsible for common not getting copied by "make install".
It appears adding "venv/scripts/common" to LIBSUBDIRS in Makefile.pre.in fixes the issue (as in the attached patch) but I've no idea if this covers all necessary platforms (I'd guess Windows doesn't use the Makefile if #22343 fixed things for it?).
|
|||
| msg285422 - (view) | Author: Zachary Ware (zach.ware) *  |
Date: 2017-01-13 17:12 | |
LGTM. |
|||
| msg285437 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2017-01-13 19:18 | |
New changeset 077681e35577 by Vinay Sajip in branch '3.5': Fixes #29261: added venv/scripts/common to LIBSUBDIRS. https://hg.python.org/cpython/rev/077681e35577 New changeset f20b2073dd4a by Vinay Sajip in branch '3.6': Fixes #29261: merged fix from 3.5. https://hg.python.org/cpython/rev/f20b2073dd4a New changeset b76c42656639 by Vinay Sajip in branch 'default': Closed #29261: merged fix from 3.6. https://hg.python.org/cpython/rev/b76c42656639 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:41 | admin | set | github: 73447 |
| 2017-01-13 19:18:44 | python-dev | set | status: open -> closed nosy: + python-dev messages: + msg285437 resolution: fixed stage: commit review -> resolved |
| 2017-01-13 17:12:55 | zach.ware | set | nosy:
+ vinay.sajip, zach.ware messages: + msg285422 assignee: vinay.sajip stage: commit review |
| 2017-01-13 15:06:25 | Dave Jones | create | |