This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: blake2: Remove unused function to avoid undefined references
Type: behavior Stage: resolved
Components: Build Versions: Python 3.6
process
Status: closed Resolution: duplicate
Dependencies: Superseder: Numerous warnings with blake2 module
View: 37055
Assigned To: Nosy List: ZackerySpytz, christian.heimes, ericvw
Priority: normal Keywords: patch

Created on 2017-01-05 22:38 by ericvw, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
blake2-remove-unused-function-1.patch ericvw, 2017-01-05 22:38
Messages (2)
msg284781 - (view) Author: Eric N. Vander Weele (ericvw) * Date: 2017-01-05 22:38
Compilers are not required to elide static functions which are unused.

Some compilers, such as Solaris Studio, always emits the function, even
if the function does not get called within the translation unit.  This
becomes problematic when a static inline function calls a non-existent
function; thus, resulting in (dynamic or static) link time errors.

Given that 'blake2' is never referenced nor called, remove the
definition of this function to increase portability for non-Linux
toolchains.

https://blogs.oracle.com/d/entry/inline_functions_in_c also indicates that this is case for Solaris Studio as well.
msg351761 - (view) Author: Zackery Spytz (ZackerySpytz) * (Python triager) Date: 2019-09-11 05:16
It seems that this was fixed as part of bpo-37055 / b27cbec801e17a13d7fef49116a8fc279930d2b1.
History
Date User Action Args
2022-04-11 14:58:41adminsetgithub: 73357
2019-09-11 09:09:56benjamin.petersonsetstatus: open -> closed
superseder: Numerous warnings with blake2 module
resolution: duplicate
stage: resolved
2019-09-11 05:16:25ZackerySpytzsetnosy: + ZackerySpytz
messages: + msg351761
2017-01-05 22:44:42ericvwsettitle: Remove unused blake2 function to avoid undefined references -> blake2: Remove unused function to avoid undefined references
2017-01-05 22:38:51ericvwcreate