This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Document recent changes in typing.py
Type: enhancement Stage: resolved
Components: Documentation Versions: Python 3.7, Python 3.6, Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: Mariatta, docs@python, gvanrossum, levkivskyi, python-dev
Priority: normal Keywords: patch

Created on 2016-11-09 00:38 by levkivskyi, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
recent-typing-docs.diff levkivskyi, 2016-11-09 00:38 review
recent-typing-docs-v2.diff levkivskyi, 2016-11-09 00:47 review
recent-typing-docs-v3.diff levkivskyi, 2016-11-09 09:00 review
recent-typing-docs-v4.diff levkivskyi, 2016-11-10 14:00 review
recent-typing-docs-v5.diff levkivskyi, 2016-11-11 15:02 review
recent-typing-docs-v6.diff levkivskyi, 2016-11-11 15:03 review
Messages (7)
msg280364 - (view) Author: Ivan Levkivskyi (levkivskyi) * (Python committer) Date: 2016-11-09 00:38
Here is the patch with recent additions/changes in typing.py

Summary: Tuple and Callable are now classes, generic type aliases, added Coroutine, extended docs for get_type_hints.
msg280366 - (view) Author: Ivan Levkivskyi (levkivskyi) * (Python committer) Date: 2016-11-09 00:47
Sorry, here is the patch with corrected formatting and base classes for Coroutine.
msg280373 - (view) Author: Mariatta (Mariatta) * (Python committer) Date: 2016-11-09 03:19
Hi Ivan, I noticed you used two space indentation in your docs patch.

Can you use 3 spaces instead?
More guidelines here:
https://docs.python.org/devguide/documenting.html?#use-of-whitespace

Thanks :)
msg280381 - (view) Author: Ivan Levkivskyi (levkivskyi) * (Python committer) Date: 2016-11-09 09:00
Thanks Mariatta, here is a new version of patch with indentation fixed.
msg280506 - (view) Author: Ivan Levkivskyi (levkivskyi) * (Python committer) Date: 2016-11-10 14:00
Guido, here is a new patch with your comments implemented.
msg280587 - (view) Author: Ivan Levkivskyi (levkivskyi) * (Python committer) Date: 2016-11-11 15:02
Guido, here is the new patch with your corrections. I have some questions in Rietveld, but those are about mypy, you could apply the patch now.
msg280623 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-11-11 23:58
New changeset 5bf2ea0d3830 by Guido van Rossum in branch '3.5':
Issue 28644: Document recent changes in typing.py (Ivan L)
https://hg.python.org/cpython/rev/5bf2ea0d3830

New changeset 72a2c90abdec by Guido van Rossum in branch '3.6':
Issue 28644: Document recent changes in typing.py (Ivan L) (3.5->3.6)
https://hg.python.org/cpython/rev/72a2c90abdec

New changeset c4394da344b7 by Guido van Rossum in branch 'default':
Issue 28644: Document recent changes in typing.py (Ivan L) (3.6->3.7)
https://hg.python.org/cpython/rev/c4394da344b7
History
Date User Action Args
2022-04-11 14:58:39adminsetgithub: 72830
2016-11-11 23:59:06gvanrossumsetstatus: open -> closed
resolution: fixed
stage: resolved
2016-11-11 23:58:39python-devsetnosy: + python-dev
messages: + msg280623
2016-11-11 15:03:49levkivskyisetfiles: + recent-typing-docs-v6.diff
2016-11-11 15:02:04levkivskyisetfiles: + recent-typing-docs-v5.diff

messages: + msg280587
2016-11-10 20:46:49gvanrossumsettitle: Document recen changes in typing.py -> Document recent changes in typing.py
2016-11-10 14:00:15levkivskyisetfiles: + recent-typing-docs-v4.diff

messages: + msg280506
2016-11-09 09:00:43levkivskyisetfiles: + recent-typing-docs-v3.diff

messages: + msg280381
2016-11-09 03:19:19Mariattasetnosy: + Mariatta
messages: + msg280373
2016-11-09 00:47:23levkivskyisetfiles: + recent-typing-docs-v2.diff

messages: + msg280366
2016-11-09 00:38:11levkivskyicreate