Issue2807
Created on 2008-05-09 22:31 by alexandre.vassalotti, last changed 2008-05-09 22:43 by alexandre.vassalotti.
| msg66495 (view) |
Author: Alexandre Vassalotti (alexandre.vassalotti) |
Date: 2008-05-09 22:31 |
|
Marc-Andre Lemburg noted:
BTW: The API PyUnicode_AsString() is pretty useless by itself - there's
no way to access the size information of the returned string without
again going to the Unicode object.
I'd suggest to remove the API altogether and not only deprecating it.
Furthermore, the API PyUnicode_AsStringAndSize() does not follow the API
signature of PyString_AsStringAndSize() in that it passes back the
pointer to the string as output parameter. That should be changed as
well. Note that PyString_AsStringAndSize() already does this for both
8-bit strings and Unicode, so the special Unicode API is not really
needed at all or you may want to rename PyString_AsStringAndSize() to
PyUnicode_AsStringAndSize().
Finally, since there are many cases where the string buffer contents are
copied to a new buffer, it's probably worthwhile to add a new API which
does the copying straight away and also deals with the overflow cases in
a central place. I'd suggest PyUnicode_AsChar() (with an API like
PyUnicode_AsWideChar()).
|
| msg66496 (view) |
Author: Alexandre Vassalotti (alexandre.vassalotti) |
Date: 2008-05-09 22:40 |
|
Honestly, I am not sure if removing PyUnicode_AsString() is a good idea.
There is many cases where the size of the returned string is not needed.
Furthermore, this would be a rather major backward-incompatible change
to be included in a beta release.
|
| msg66497 (view) |
Author: Alexandre Vassalotti (alexandre.vassalotti) |
Date: 2008-05-09 22:43 |
|
Oops, it seems Marc-André has already opened an issue about this.
Closing as duplicate.
|
|
| Date |
User |
Action |
Args |
| 2008-05-09 22:43:17 | alexandre.vassalotti | set | status: open -> closed superseder: Remove PyUnicode_AsString(), rework PyUnicode_AsStringAndSize(), add PyUnicode_AsChar() messages:
+ msg66497 resolution: duplicate |
| 2008-05-09 22:40:00 | alexandre.vassalotti | set | messages:
+ msg66496 |
| 2008-05-09 22:31:26 | alexandre.vassalotti | create | |
|