➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2016-08-12 17:12 by zach.ware, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| simplify_test_winsound.diff | zach.ware, 2016-08-12 17:12 | review | ||
| Messages (4) | |||
|---|---|---|---|
| msg272546 - (view) | Author: Zachary Ware (zach.ware) *  |
Date: 2016-08-12 17:12 | |
test_winsound is rather annoying. It currently attempts to determine whether a sound card is present, and whether particular system sounds are available. These checks are fragile at best, and I routinely see failures that shouldn't be. In particular, if I have an open RDP session to my ware-win81-release buildbot, test_winsound fails because it thinks the sounds should fail to play, but instead they succeed. Rather than attempt to make the checks more robust, I suggest that we instead rip out the checks and simply ensure that each call that might succeed either returns normally or raises RuntimeError. After all, we can't actually test whether a sound really played or not. |
|||
| msg274433 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2016-09-05 21:15 | |
New changeset 4c91651912d1 by Zachary Ware in branch '2.7': Issue #27748: Simplify test_winsound. https://hg.python.org/cpython/rev/4c91651912d1 New changeset 82467d0dbaea by Zachary Ware in branch '3.5': Issue #27748: Simplify test_winsound. https://hg.python.org/cpython/rev/82467d0dbaea New changeset 27cbdd8cf67f by Zachary Ware in branch 'default': Closes #27748: Merge with 3.5 https://hg.python.org/cpython/rev/27cbdd8cf67f |
|||
| msg274450 - (view) | Author: Roundup Robot (python-dev) |
Date: 2016-09-05 22:24 | |
New changeset 6137d0ed0a15 by Zachary Ware in branch '2.7': Issue #27748: strengthen test_alias_nofallback https://hg.python.org/cpython/rev/6137d0ed0a15 New changeset f845e24d794e by Zachary Ware in branch '3.5': Issue #27748: strengthen test_alias_nofallback https://hg.python.org/cpython/rev/f845e24d794e New changeset 5e8b865ffedd by Zachary Ware in branch 'default': Issue #27748: Merge with 3.5 https://hg.python.org/cpython/rev/5e8b865ffedd |
|||
| msg274459 - (view) | Author: Roundup Robot (python-dev) |
Date: 2016-09-05 23:10 | |
New changeset fb74947843eb by Zachary Ware in branch '2.7': Issue #27748: Backed out changeset 6137d0ed0a15 https://hg.python.org/cpython/rev/fb74947843eb New changeset e85ce70b73b3 by Zachary Ware in branch '3.5': Issue #27748: Backed out changeset f845e24d794e https://hg.python.org/cpython/rev/e85ce70b73b3 New changeset 29300ed6dffe by Zachary Ware in branch 'default': Issue #27748: Merge with 3.5 https://hg.python.org/cpython/rev/29300ed6dffe |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:34 | admin | set | github: 71935 |
| 2016-09-05 23:10:53 | python-dev | set | messages: + msg274459 |
| 2016-09-05 22:24:55 | python-dev | set | messages: + msg274450 |
| 2016-09-05 21:15:39 | python-dev | set | status: open -> closed nosy: + python-dev messages: + msg274433 resolution: fixed stage: patch review -> resolved |
| 2016-08-12 17:12:35 | zach.ware | create | |