➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2016-08-04 08:51 by holdenweb, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| README.patch | holdenweb, 2016-08-04 08:51 | review | ||
| README2.patch | holdenweb, 2016-08-04 09:27 | Updated to remove dyslexic errors | review | |
| Messages (7) | |||
|---|---|---|---|
| msg271958 - (view) | Author: Steve Holden (holdenweb) *  |
Date: 2016-08-04 08:51 | |
I have seen a relatively large number of pull requests via the Github mirror repository, because would-be contributors presumably just look on Github and, having found Python there, assume this is the place for contributions. The standard README file gives no clue that the Github repository should not be used as the basis for contributory pull requests, and neither should it. Fortunately Github will display a README.md file in preference to REAMDE when one is found. This patch adds a message, highly visible to Github users, that they are in the wrong place. For an indication of how the Github page will then look, visit https://github.com/holdenweb/python/tree/README where the patch is already installed. |
|||
| msg271961 - (view) | Author: Steve Holden (holdenweb) * |
Date: 2016-08-04 09:27 | |
Hmm, not sure I quite understand how to interact with this tracker. So here's an updated patch that I thought I had already submitted ... |
|||
| msg271965 - (view) | Author: Berker Peksag (berker.peksag) * |
Date: 2016-08-04 09:47 | |
I find pull requests templates more useful: https://github.com/blog/2111-issue-and-pull-request-templates and we already have a template to warn users: https://github.com/python/cpython/blob/master/.github/PULL_REQUEST_TEMPLATE.md |
|||
| msg271968 - (view) | Author: Steve Holden (holdenweb) * |
Date: 2016-08-04 11:57 | |
I don't seem to be able to activate the PR template, but if you are happy it works then I guess this would be a belt-and-braces change. If nobody merges it and it gets closed that's fine, but if it obviates just a few pull requests it will save both the core devs and the contributors some time. |
|||
| msg271971 - (view) | Author: R. David Murray (r.david.murray) * |
Date: 2016-08-04 13:05 | |
Just FYI Steve, the pull request template is relatively recent addition (within the last two months). |
|||
| msg271978 - (view) | Author: Steve Holden (holdenweb) * |
Date: 2016-08-04 14:21 | |
Hmm. Tried making a PR to a forked copy and didn't see it. Probably just incompetence on my part. |
|||
| msg271980 - (view) | Author: Berker Peksag (berker.peksag) * |
Date: 2016-08-04 14:33 | |
Sorry, I forgot to share a screenshot in my earlier message: https://dl.dropboxusercontent.com/u/166024/pr-template.png |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:34 | admin | set | github: 71867 |
| 2016-09-11 04:07:24 | berker.peksag | set | status: open -> closed resolution: out of date stage: patch review -> resolved |
| 2016-08-04 14:33:43 | berker.peksag | set | messages: + msg271980 |
| 2016-08-04 14:21:21 | holdenweb | set | messages: + msg271978 |
| 2016-08-04 13:05:06 | r.david.murray | set | nosy:
+ r.david.murray messages: + msg271971 |
| 2016-08-04 11:57:36 | holdenweb | set | messages: + msg271968 |
| 2016-08-04 09:47:19 | berker.peksag | set | nosy:
+ berker.peksag messages: + msg271965 |
| 2016-08-04 09:27:07 | holdenweb | set | files:
+ README2.patch messages: + msg271961 |
| 2016-08-04 08:51:15 | holdenweb | create | |