➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2016-05-25 06:12 by xiang.zhang, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| Py_XDECREF_in_typeobject.diff | xiang.zhang, 2016-05-25 06:12 | review | ||
| Messages (6) | |||
|---|---|---|---|
| msg266307 - (view) | Author: Xiang Zhang (xiang.zhang) *  |
Date: 2016-05-25 06:12 | |
Several Py_XDECREFs are not necessary since the pointers they handle cannot be NULL. |
|||
| msg266310 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2016-05-25 06:39 | |
LGTM. |
|||
| msg266342 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2016-05-25 13:03 | |
LGTM too. Serhiy, do you want to push the patch? |
|||
| msg266345 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2016-05-25 13:15 | |
New changeset 3b4c3dda679a by Serhiy Storchaka in branch 'default': Issue #27118: Clean up Py_XINCREF/Py_XDECREF in typeobject.c. https://hg.python.org/cpython/rev/3b4c3dda679a |
|||
| msg266346 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2016-05-25 13:16 | |
Done. Thank you for your contribution Xiang Zhang. |
|||
| msg266355 - (view) | Author: Xiang Zhang (xiang.zhang) * |
Date: 2016-05-25 13:48 | |
It's my pleasure and thanks for your time reviewing this thread too. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:31 | admin | set | github: 71305 |
| 2016-05-25 13:48:29 | xiang.zhang | set | messages: + msg266355 |
| 2016-05-25 13:16:35 | serhiy.storchaka | set | status: open -> closed resolution: fixed messages: + msg266346 stage: commit review -> resolved |
| 2016-05-25 13:15:27 | python-dev | set | nosy:
+ python-dev messages: + msg266345 |
| 2016-05-25 13:03:00 | vstinner | set | nosy:
+ vstinner messages: + msg266342 |
| 2016-05-25 12:43:04 | serhiy.storchaka | set | assignee: serhiy.storchaka |
| 2016-05-25 06:39:22 | serhiy.storchaka | set | type: behavior -> enhancement messages: + msg266310 stage: patch review -> commit review |
| 2016-05-25 06:30:24 | SilentGhost | set | nosy:
+ serhiy.storchaka type: enhancement -> behavior components: + Interpreter Core stage: patch review |
| 2016-05-25 06:14:39 | xiang.zhang | set | title: Several Py_XDECREFs in typeobject.c are not necessary -> Several Py_XDE/INCREFs in typeobject.c are not necessary |
| 2016-05-25 06:13:11 | xiang.zhang | set | versions:
+ Python 3.6 type: enhancement title: Several Py_XDECREFs are not necessary -> Several Py_XDECREFs in typeobject.c are not necessary |
| 2016-05-25 06:12:40 | xiang.zhang | create | |