➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2016-05-24 20:30 by Unit03, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| mailbox_all.patch | Unit03, 2016-05-24 20:30 | review | ||
| Messages (9) | |||
|---|---|---|---|
| msg266267 - (view) | Author: Jacek Kołodziej (Unit03) * | Date: 2016-05-24 20:30 | |
That's a child issue of #23883, created to propose a patch fixing mailbox module's __all__ list. |
|||
| msg266273 - (view) | Author: R. David Murray (r.david.murray) *  |
Date: 2016-05-24 20:50 | |
Rather than adding the new class to the list of tests, we could take this opportunity to convert this test file to the new format, unless there's some reason that doesn't work (I don't expect there to be). |
|||
| msg266279 - (view) | Author: Jacek Kołodziej (Unit03) * | Date: 2016-05-24 21:19 | |
David, what do you mean by "new format"? Can you point me to some existing code? |
|||
| msg266280 - (view) | Author: R. David Murray (r.david.murray) * |
Date: 2016-05-24 21:32 | |
Look at your mimetypes patch, for example. That if __name__='__main__' clause is all that is needed. The test_main stuff can be dropped. The question, I suppose, is the reap_children call, and that may be why it hasn't been converted yet. |
|||
| msg266297 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2016-05-25 03:58 | |
Yes, the reap_children call is the culprit. I think resolving this problem is out of the scope of this simple issue (there is separate issue for this). |
|||
| msg266325 - (view) | Author: Martin Panter (martin.panter) * |
Date: 2016-05-25 09:17 | |
This patch looks good to me. I agree the reap_children() thing is a separate problem. |
|||
| msg267505 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2016-06-06 02:30 | |
New changeset 4705b7597c86 by Martin Panter in branch 'default': Issue #27107: Add exception classes to mailbox.__all__, by Jacek Kołodziej https://hg.python.org/cpython/rev/4705b7597c86 |
|||
| msg267512 - (view) | Author: Roundup Robot (python-dev) |
Date: 2016-06-06 02:53 | |
New changeset d62e57958e7c by Martin Panter in branch 'default': Issue #27107: mailbox.fcntl = None on Windows https://hg.python.org/cpython/rev/d62e57958e7c |
|||
| msg267515 - (view) | Author: Martin Panter (martin.panter) * |
Date: 2016-06-06 03:05 | |
FTR the closest thing I could find discussing reap_children() is Issue 16968. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:31 | admin | set | github: 71294 |
| 2016-06-06 03:05:35 | martin.panter | set | status: open -> closed resolution: fixed messages: + msg267515 stage: patch review -> resolved |
| 2016-06-06 02:53:43 | python-dev | set | messages: + msg267512 |
| 2016-06-06 02:30:51 | python-dev | set | nosy:
+ python-dev messages: + msg267505 |
| 2016-05-25 13:16:53 | martin.panter | link | issue23883 dependencies |
| 2016-05-25 09:17:12 | martin.panter | set | nosy:
+ martin.panter messages: + msg266325 stage: patch review |
| 2016-05-25 03:58:45 | serhiy.storchaka | set | nosy:
+ serhiy.storchaka messages: + msg266297 |
| 2016-05-24 21:32:47 | r.david.murray | set | messages: + msg266280 |
| 2016-05-24 21:19:58 | Unit03 | set | messages: + msg266279 |
| 2016-05-24 20:50:37 | r.david.murray | set | nosy:
+ r.david.murray messages: + msg266273 |
| 2016-05-24 20:30:14 | Unit03 | create | |