This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Some unittest loader tests are silently skipped by mistake
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.6, Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: berker.peksag, ezio.melotti, michael.foord, python-dev, rbcollins, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2016-05-19 20:31 by serhiy.storchaka, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
test_loader.patch serhiy.storchaka, 2016-05-19 20:31 review
Messages (5)
msg265894 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2016-05-19 20:31
Due to bug in the decorator some tests in Lib/unittest/test/test_loader.py are silently skipped. Proposed patch fixes this as well as other bugs in the decorator and tests.
msg265957 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2016-05-20 20:04
LGTM. Just curious, did you find it by reading code or by using some tool?
msg265958 - (view) Author: Robert Collins (rbcollins) * (Python committer) Date: 2016-05-20 20:06
LGTM too
msg265959 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-05-20 20:30
New changeset e715ffd2d938 by Serhiy Storchaka in branch '3.5':
Issue #27063: Some unittest loader tests were silently skipped.
https://hg.python.org/cpython/rev/e715ffd2d938

New changeset f4f615edb6b1 by Serhiy Storchaka in branch 'default':
Issue #27063: Some unittest loader tests were silently skipped.
https://hg.python.org/cpython/rev/f4f615edb6b1
msg265960 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2016-05-20 20:55
Thank you for review.

I found this when wrote patches for removing deprecated features.
History
Date User Action Args
2022-04-11 14:58:31adminsetgithub: 71250
2016-05-20 20:55:49serhiy.storchakasetstatus: open -> closed
resolution: fixed
messages: + msg265960

stage: commit review -> resolved
2016-05-20 20:30:14python-devsetnosy: + python-dev
messages: + msg265959
2016-05-20 20:06:57rbcollinssetmessages: + msg265958
2016-05-20 20:04:57berker.peksagsetnosy: + berker.peksag

messages: + msg265957
stage: patch review -> commit review
2016-05-19 20:31:11serhiy.storchakacreate