➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2016-04-17 06:21 by gregory.p.smith, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| issue26787.patch | alecsandru.patrascu, 2016-04-18 13:46 | review | ||
| Messages (7) | |||
|---|---|---|---|
| msg263598 - (view) | Author: Gregory P. Smith (gregory.p.smith) *  |
Date: 2016-04-17 06:21 | |
When configured using './configure --with-lto' (added in issue25702) and doing a 'make profile-opt' build, test_distutils fails: ====================================================================== FAIL: test_sysconfig_compiler_vars (distutils.tests.test_sysconfig.SysconfigTestCase) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/greg/sandbox/python/cpython/3.5/Lib/distutils/tests/test_sysconfig.py", line 156, in test_sysconfig_compiler_vars sysconfig.get_config_var('LDSHARED')) AssertionError: 'gcc -pthread -shared -flto -fuse-linker-plugin -ffat-lto-obje[20 chars]none' != 'gcc -pthread -shared' - gcc -pthread -shared -flto -fuse-linker-plugin -ffat-lto-objects -flto-partition=none + gcc -pthread -shared ====================================================================== FAIL: test_sysconfig_module (distutils.tests.test_sysconfig.SysconfigTestCase) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/greg/sandbox/python/cpython/3.5/Lib/distutils/tests/test_sysconfig.py", line 133, in test_sysconfig_module sysconfig.get_config_var('LDFLAGS')) AssertionError: '-flto -fuse-linker-plugin -ffat-lto-objects -flto-partition=none' != '' - -flto -fuse-linker-plugin -ffat-lto-objects -flto-partition=none + |
|||
| msg263624 - (view) | Author: Alecsandru Patrascu (alecsandru.patrascu) * | Date: 2016-04-17 19:52 | |
I will investigate this and submit a fix. At a first glance, it seems the test is failing because it does not have the knowledge of the LTO flags. |
|||
| msg263666 - (view) | Author: Alecsandru Patrascu (alecsandru.patrascu) * | Date: 2016-04-18 13:46 | |
Hello, You can find a patch for this issue attached. Basically, since LTO needs LD flags when used, I modified the makefile template file and the test to push the flags up to the sysconfig module. |
|||
| msg263673 - (view) | Author: Alecsandru Patrascu (alecsandru.patrascu) * | Date: 2016-04-18 16:55 | |
This patch is for CPython 3, and if it looks good I will post also the CPython 2 version. |
|||
| msg284027 - (view) | Author: Inada Naoki (methane) * |
Date: 2016-12-26 13:13 | |
LGTM |
|||
| msg287978 - (view) | Author: Inada Naoki (methane) * |
Date: 2017-02-17 08:40 | |
Would you send pull request on Github? |
|||
| msg336187 - (view) | Author: Inada Naoki (methane) * |
Date: 2019-02-21 06:59 | |
Fixed in bpo-35257 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:29 | admin | set | github: 70974 |
| 2019-02-21 06:59:15 | methane | set | status: open -> closed resolution: fixed messages: + msg336187 stage: resolved |
| 2017-02-17 08:40:38 | methane | set | messages: + msg287978 |
| 2016-12-26 13:13:06 | methane | set | nosy:
+ methane messages: + msg284027 |
| 2016-04-18 16:55:22 | alecsandru.patrascu | set | messages: + msg263673 |
| 2016-04-18 13:46:45 | alecsandru.patrascu | set | files:
+ issue26787.patch keywords: + patch messages: + msg263666 |
| 2016-04-17 19:52:48 | alecsandru.patrascu | set | messages: + msg263624 |
| 2016-04-17 06:21:50 | gregory.p.smith | link | issue25702 dependencies |
| 2016-04-17 06:21:25 | gregory.p.smith | create | |