This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: fix broken link to hamcrest.library.integration.match_equality in unittest.mock "getting started" documentation
Type: Stage: resolved
Components: Documentation Versions: Python 3.6, Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: berker.peksag, das-g, docs@python, python-dev
Priority: normal Keywords: patch

Created on 2016-01-25 16:20 by das-g, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
0d413f60cc23.diff das-g, 2016-01-25 16:27
fix-broken-link-to-pyhamcrest-match_equality.diff das-g, 2016-01-25 16:56 patch review
Repositories containing patches
https://bitbucket.org/das_g/cpython
Messages (6)
msg258906 - (view) Author: Raphael Das Gupta (das-g) * Date: 2016-01-25 16:20
On

* https://docs.python.org/3.3/library/unittest.mock-examples.html#more-complex-argument-matching
* https://docs.python.org/3.4/library/unittest.mock-examples.html#more-complex-argument-matching
* https://docs.python.org/3.5/library/unittest.mock-examples.html#more-complex-argument-matching
* https://docs.python.org/3.6/library/unittest.mock-examples.html#more-complex-argument-matching

the link to hamcrest.library.integration.match_equality documentation at the very end of the page is broken.

(Earlier versions didn't have this documentation page.)
msg258909 - (view) Author: Raphael Das Gupta (das-g) * Date: 2016-01-25 16:56
0d413f60cc23.diff generated with the 'Create Patch' button of this bug tracker is crap. (I guess it's a diff of upstream's tip to my repo's tip, thus reverting all changes of upstream that this daggy fix isn't based on.)

Use fix-broken-link-to-pyhamcrest-match_equality.diff instead. (Created with hg export.)
msg259096 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-01-28 06:40
New changeset e4b0f003ad13 by Berker Peksag in branch '3.5':
Issue #26199: Fix broken link in unittest.mock-examples.rst
https://hg.python.org/cpython/rev/e4b0f003ad13

New changeset 7c38a47fd4d5 by Berker Peksag in branch 'default':
Issue #26199: Fix broken link in unittest.mock-examples.rst
https://hg.python.org/cpython/rev/7c38a47fd4d5
msg259097 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2016-01-28 06:41
Thanks for the patch, Raphael!
msg259125 - (view) Author: Raphael Das Gupta (das-g) * Date: 2016-01-28 12:48
You're welcome. Thanks for applying the patch.

Shouldn't it be applied to other affected versions (3.3 and 3.4), too, though?
msg259126 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2016-01-28 13:07
3.3 and 3.4 are in security-fix-only mode, which means they won't get bugfix and documentation updates anymore. See https://docs.python.org/devguide/devcycle.html for details.
History
Date User Action Args
2022-04-11 14:58:26adminsetgithub: 70387
2016-01-28 13:07:59berker.peksagsetmessages: + msg259126
2016-01-28 12:48:36das-gsetmessages: + msg259125
2016-01-28 06:41:58berker.peksagsetstatus: open -> closed

versions: - Python 3.3, Python 3.4
nosy: + berker.peksag

messages: + msg259097
resolution: fixed
stage: resolved
2016-01-28 06:40:24python-devsetnosy: + python-dev
messages: + msg259096
2016-01-25 16:56:06das-gsetfiles: + fix-broken-link-to-pyhamcrest-match_equality.diff

messages: + msg258909
2016-01-25 16:42:26das-gsetfiles: + 0d413f60cc23.diff
keywords: + patch
2016-01-25 16:20:52das-gcreate