This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Event's test_reset_internal_locks too fragile
Type: enhancement Stage: resolved
Components: Tests Versions: Python 3.6, Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: berker.peksag, nirs, python-dev
Priority: normal Keywords: patch

Created on 2015-11-04 22:45 by nirs, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
0001-Issue-254074-Test-condition-behavior-instead-of-inte.patch nirs, 2015-11-04 22:50 Less fragile test
Messages (3)
msg254074 - (view) Author: Nir Soffer (nirs) * Date: 2015-11-04 22:45
test_reset_internal_locks is looking at Event's _cond._lock - this make it harder to change internal details of the Condition object and make the test fragile.

We should test the condition behavior instead.
msg264500 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-04-29 14:26
New changeset 110dfb244b27 by Berker Peksag in branch '3.5':
Issue #25551: Test condition behavior instead of its internals
https://hg.python.org/cpython/rev/110dfb244b27

New changeset 9694185cdd9f by Berker Peksag in branch 'default':
Issue #25551: Test condition behavior instead of its internals
https://hg.python.org/cpython/rev/9694185cdd9f
msg264501 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2016-04-29 14:26
Thanks for the patch, Nir!
History
Date User Action Args
2022-04-11 14:58:23adminsetgithub: 69737
2016-04-29 14:26:53berker.peksagsetstatus: open -> closed

versions: + Python 3.5
nosy: + berker.peksag

messages: + msg264501
resolution: fixed
stage: resolved
2016-04-29 14:26:05python-devsetnosy: + python-dev
messages: + msg264500
2015-11-04 22:50:54nirssetfiles: + 0001-Issue-254074-Test-condition-behavior-instead-of-inte.patch
keywords: + patch
2015-11-04 22:45:50nirscreate