➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2008-04-03 00:26 by amaury.forgeotdarc, last changed 2022-04-11 14:56 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| buffer.patch | amaury.forgeotdarc, 2008-04-03 00:26 | |||
| Messages (6) | |||
|---|---|---|---|
| msg64886 - (view) | Author: Amaury Forgeot d'Arc (amaury.forgeotdarc) *  |
Date: 2008-04-03 00:26 | |
Bytes should be immutable, but in test_socket.py:
buf = b" "*1024
nbytes = self.cli_conn.recv_into(buf)
This patch attempts to enforce readonly buffer on bytes
|
|||
| msg64964 - (view) | Author: Neal Norwitz (nnorwitz) * |
Date: 2008-04-05 04:55 | |
Travis, could you take a look? |
|||
| msg65068 - (view) | Author: Gregory P. Smith (gregory.p.smith) * |
Date: 2008-04-07 07:42 | |
This patch looks good. One question: in Objects/abstract.c in PyBuffer_FillInfo, why is it even testing for the PyBUF_LOCK flag at all? PEP 3118 says its valid for both reading and writing (if the underlying object supports locked access). BTW, I is someone is going to merge any py3k buffer api related changes back into the backport that is in 2.6? |
|||
| msg70357 - (view) | Author: Benjamin Peterson (benjamin.peterson) * |
Date: 2008-07-28 17:00 | |
How's this coming? |
|||
| msg70390 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2008-07-29 13:12 | |
The patch should probably come with a test :) |
|||
| msg70644 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2008-08-02 21:03 | |
Fixed in r65420, with a test. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:56:32 | admin | set | github: 46790 |
| 2008-08-02 21:03:18 | pitrou | set | status: open -> closed resolution: fixed messages: + msg70644 |
| 2008-07-29 13:13:00 | pitrou | set | nosy:
+ pitrou messages: + msg70390 |
| 2008-07-28 17:00:10 | benjamin.peterson | set | priority: critical -> release blocker messages: + msg70357 |
| 2008-05-23 22:51:53 | benjamin.peterson | set | nosy: + benjamin.peterson |
| 2008-05-23 22:47:01 | benjamin.peterson | set | priority: critical type: behavior |
| 2008-04-30 17:40:36 | theller | set | nosy: + theller |
| 2008-04-07 07:42:05 | gregory.p.smith | set | messages: + msg65068 |
| 2008-04-05 04:55:50 | nnorwitz | set | assignee: teoliphant messages: + msg64964 nosy: + nnorwitz, teoliphant |
| 2008-04-03 01:17:53 | gregory.p.smith | set | nosy: + gregory.p.smith |
| 2008-04-03 00:26:22 | amaury.forgeotdarc | create | |