This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Add doc for tkinter commondialog.Dialog and subclasses
Type: enhancement Stage: resolved
Components: Documentation Versions: Python 3.6, Python 3.5, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: docs@python, mdk, npatel, serhiy.storchaka, terry.reedy
Priority: normal Keywords:

Created on 2015-09-26 03:03 by terry.reedy, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 1870 merged npatel, 2017-05-30 20:34
Messages (5)
msg251630 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2015-09-26 03:03
As noted in #15346, several modules are not documented except in the code.  Having just had to do that for #25173, I would like there to be a page for commondialog.Dialog and its subclasses, messagebox.Message and colorchooser.Chooser, and the associated module functions.  I hope to submit a .rst file for review if no one else does so.  My plan is to copy from web pages produced by the pydoc server, add markup, and edit.
msg251633 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2015-09-26 03:42
Side issue: Dialog has this:
        # we need a dummy widget to properly process the options
        # (at least as long as we use Tkinter 1.63)
        w = Frame(self.master)

Do you know what 'Tkinter 1.63' refers to?  In 2.7, Tkinter.__version__ is '$Revision: 81008 $'.  If self.master is not None, I would expect that it can be used in
            s = w.tk.call(self.command, *w._options(self.options))
            s = self._fixresult(w, s)
msg294788 - (view) Author: Nikhil Patel (npatel) * Date: 2017-05-30 21:31
I've written rst files containing documentation for the tkinter modules and submitted a PR. Attempted to mimic the wording as well as style of existing documentation to keep it consistent.
msg318506 - (view) Author: Nikhil Patel (npatel) * Date: 2018-06-02 17:26
PR to add documentation still up-to-date and all checks successful just pending review
msg351593 - (view) Author: Julien Palard (mdk) * (Python committer) Date: 2019-09-10 08:55
New changeset 80428ed4e19b31071433806b4d89465c88e084c6 by Julien Palard (Nikhil) in branch 'master':
bpo-25237: Documentation for tkinter modules (GH-1870)
https://github.com/python/cpython/commit/80428ed4e19b31071433806b4d89465c88e084c6
History
Date User Action Args
2022-04-11 14:58:21adminsetgithub: 69424
2022-01-30 00:09:22iritkatriellinkissue30210 superseder
2019-09-10 08:56:16mdksetstatus: open -> closed
resolution: fixed
stage: needs patch -> resolved
2019-09-10 08:55:37mdksetnosy: + mdk
messages: + msg351593
2018-06-02 17:26:48npatelsetnosy: + docs@python
messages: + msg318506

assignee: docs@python
components: + Documentation
2017-05-30 21:31:32npatelsetnosy: + npatel
messages: + msg294788
2017-05-30 20:34:05npatelsetpull_requests: + pull_request1953
2015-09-26 03:42:47terry.reedysetmessages: + msg251633
2015-09-26 03:04:59terry.reedylinkissue15346 dependencies
2015-09-26 03:03:32terry.reedycreate