This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Windows x86-64 embeddable zip file contains test directorys
Type: enhancement Stage: resolved
Components: Installation, Windows Versions: Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: steve.dower Nosy List: paul.moore, python-dev, steve.dower, tds333, terry.reedy, tim.golden, zach.ware
Priority: normal Keywords:

Created on 2015-09-13 13:45 by tds333, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Messages (7)
msg250563 - (view) Author: Wolfgang Langner (tds333) * Date: 2015-09-13 13:45
The Windows x86-64 embeddable zip file (and possible the one for 32bit)
includes some unnecessary test folders in python35.zip with test scripts.

python35.zip\distutils\tests\
python35.zip\unittest\test\
python35.zip\lib2to3\tests\
python35.zip\ctypes\test\
python35.zip\sqlite3\test\

Python Version 3.5 rc4

This is only a minor issue, because it affects only size not functionality.
msg251023 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2015-09-18 19:54
tkinter\test and idlelib\idle_test are others. I presume all these directories are installed in a normal install even when "[] include tests" is left unchecked.

There is one non-unittest file in idle_help, htest.py, that I would not want omitted, as I believe there may be reasons, especially in the future, for users to run it.  I could move it up into idlelib itself. This is probably an anomaly, but it might be a good idea to check with maintainers of each package.
msg251354 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2015-09-22 22:10
True, those files aren't needed in the embeddable distro.

Terry - you're right, if someone chooses to install Tcl/Tk/idle then they'll get the tests for them as well, regardless of their test suite selection. Since we're not really talking about a lot of files, I'd rather leave them this way (which I think is what you're also suggesting?) than deal with the cross-installer dependencies that would exist otherwise.
msg251369 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-09-23 00:01
New changeset 812e30f67d6e by Steve Dower in branch '3.5':
Closes #25085 and #25086: Exclude distutils and test directories from embeddable distro.
https://hg.python.org/cpython/rev/812e30f67d6e
msg251390 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2015-09-23 01:53
If the Tcl/Tk/Idle bundle is installed, then I prefer that /idle-test be included, even if '[ ] include tests' is left blank, as I may someday make part of it runnable from the help menu.  IE, the status quo. I do not care about any of the other package test directories.

If I understand the patch correctly, you already excluded the tkinter bundle from the embeddable zip.  The change I see is elimination of site-packages (#?????) and *.exe (#26086).  It appears that you rejected the proposal in this issue, so the resolution should say so.
msg251393 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2015-09-23 02:12
The change is for two issues. I now filter out "Lib\*\test" and "Lib\*\tests" for this one, and bdist_wininst.py and *.exe for #25086. I believe that's what the suggestions were - the regular installer (that we've been discussing) wasn't mentioned in the original post.

(Adding site-packages to the set is a bit of tidying that I noticed while fixing the others. It doesn't have an issue anywhere.)
msg251450 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2015-09-23 20:53
Thanks, re-reading I see the new exclusion test for this issue:
  if name in {'test', 'tests'} and p.parts[-3].lower() == 'lib':
History
Date User Action Args
2022-04-11 14:58:20adminsetgithub: 69272
2015-09-23 20:53:20terry.reedysetmessages: + msg251450
2015-09-23 02:12:17steve.dowersetmessages: + msg251393
2015-09-23 01:53:20terry.reedysetmessages: + msg251390
2015-09-23 00:01:53python-devsetstatus: open -> closed

nosy: + python-dev
messages: + msg251369

resolution: fixed
stage: resolved
2015-09-22 22:10:08steve.dowersetassignee: steve.dower
2015-09-22 22:10:00steve.dowersetmessages: + msg251354
2015-09-18 19:54:59terry.reedysetnosy: + terry.reedy
messages: + msg251023
2015-09-13 13:45:45tds333create