This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Conditionalize 3.5 additions to the stable ABI
Type: Stage: resolved
Components: Extension Modules, Interpreter Core Versions: Python 3.6, Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: ncoghlan, petr.viktorin, python-dev
Priority: normal Keywords: patch

Created on 2015-06-02 18:54 by petr.viktorin, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
guard-stable-api.patch petr.viktorin, 2015-06-02 18:54 review
Messages (4)
msg244684 - (view) Author: Petr Viktorin (petr.viktorin) * (Python committer) Date: 2015-06-02 18:54
I have sent patches to 3.5 that add new stable API, and later I learned [0] that additions should be conditional on the value of Py_LIMITED_API.
This patch adds #ifdef blocks for what was added in issues #24268 and #24345.


[0] https://mail.python.org/pipermail/python-dev/2015-June/140425.html
msg244685 - (view) Author: Petr Viktorin (petr.viktorin) * (Python committer) Date: 2015-06-02 18:56
I meant "stable ABI", of course
msg244705 - (view) Author: Nick Coghlan (ncoghlan) * (Python committer) Date: 2015-06-02 22:29
Looks good to me.
msg244711 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-06-02 23:14
New changeset c835dd16539a by Yury Selivanov in branch '3.5':
Issue 24365: Conditionalize PEP 489 additions to the stable ABI
https://hg.python.org/cpython/rev/c835dd16539a

New changeset fd265fa89c36 by Yury Selivanov in branch 'default':
Issue 24365: Merge 3.5
https://hg.python.org/cpython/rev/fd265fa89c36
History
Date User Action Args
2022-04-11 14:58:17adminsetgithub: 68553
2015-06-02 23:14:57yselivanovsetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2015-06-02 23:14:43python-devsetnosy: + python-dev
messages: + msg244711
2015-06-02 22:29:03ncoghlansetmessages: + msg244705
2015-06-02 19:25:39yselivanovsetnosy: + ncoghlan

stage: patch review
2015-06-02 18:56:02petr.viktorinsetmessages: + msg244685
title: Conditionalize 3.5 additions to the stable API -> Conditionalize 3.5 additions to the stable ABI
2015-06-02 18:54:59petr.viktorincreate