➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2015-02-27 16:14 by martius, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Messages (3) | |||
|---|---|---|---|
| msg236777 - (view) | Author: Martin Richard (martius) * | Date: 2015-02-27 16:14 | |
base_subprocess.BaseSuprocessTransport implements _make_write_subprocess_pipe_proto and _make_read_subprocess_pipe_proto. Both are private and both raise NotImplementedError. However, when I grep in tulip sources for those methods, they are never called nor overridden by subclasses of BaseSuprocessTransport. Shouldn't they be removed? |
|||
| msg236788 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2015-02-27 16:51 | |
New changeset 0b390b5a6729 by Victor Stinner in branch '3.4': Issue #23537: Remove 2 unused private methods of asyncio.BaseSubprocessTransport https://hg.python.org/cpython/rev/0b390b5a6729 |
|||
| msg236789 - (view) | Author: STINNER Victor (vstinner) *  |
Date: 2015-02-27 16:52 | |
Yeah, they are completly useless. Thanks for the report Martin. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:13 | admin | set | github: 67725 |
| 2015-02-27 16:52:20 | vstinner | set | status: open -> closed resolution: fixed messages: + msg236789 |
| 2015-02-27 16:51:09 | python-dev | set | nosy:
+ python-dev messages: + msg236788 |
| 2015-02-27 16:14:29 | martius | create | |