This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: add-to-pydotorg does not support .exe installers for Windows
Type: behavior Stage: resolved
Components: Build Versions: Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: georg.brandl Nosy List: georg.brandl, larry, steve.dower
Priority: normal Keywords: patch

Created on 2015-02-08 22:13 by larry, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
larry.add-to-pydotorg.exe.support.1.diff larry, 2015-02-09 17:51 Attempted diff to add support for exe installers to add-to-pydotorg.
Messages (7)
msg235571 - (view) Author: Larry Hastings (larry) * (Python committer) Date: 2015-02-08 22:13
Steve is using new technology to make the installers for Windows.  He generates four installers now:

* .exe for Win32
* -amd64.exe for Win64
* -webinstall.exe for Win32 web-based installers
* -amd64-webinstall.exe for Win64 web-based installers

add-to-pydotorg does not recognize these.

I attempted to hack it up to add support for them.  All I did was modify the "file_descriptions" structure, adding new lines for each of the four new types.  I believe my edits worked fine, but it failed to add three of the four installers.  The first .exe it processed worked (the plain ".exe", the Win32 non-web-based installer).  But the last three failed with the error message:

    Sorry, this request could not be processed. Please try again later.
msg235573 - (view) Author: Larry Hastings (larry) * (Python committer) Date: 2015-02-08 22:41
I should add, adding the files by hand worked fine.  (Which means that if you experiment with the script, when it blows away the files and re-adds them, you'll be blowing away the files I added by hand.  So if you do so, it's up to you to ensure the files are restored when you're done... one way or another.)
msg235593 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2015-02-09 06:30
Can you attach the diff you made?
msg235624 - (view) Author: Larry Hastings (larry) * (Python committer) Date: 2015-02-09 17:51
Attached for your reading pleasure.
msg237618 - (view) Author: Larry Hastings (larry) * (Python committer) Date: 2015-03-09 09:23
Using it with 3.5.0a2, it still printed the "could not be processed" error message, but there's a new wrinkle: the one executable it processed, it added incorrectly.  The "-amd64-webinstall" exe was identified as "Windows x86 executable installer".
msg237698 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2015-03-09 19:31
Well, it's not a complicated script.  You're welcome to try and debug it, but if the bug is in the depths of new pydotorg, I don't know how easy it is to find.
msg250168 - (view) Author: Larry Hastings (larry) * (Python committer) Date: 2015-09-08 07:53
I fixed it.  My original attempted hack had bad regular expressions.  Once my regular expressions worked properly it was all fine.
History
Date User Action Args
2022-04-11 14:58:12adminsetgithub: 67603
2015-09-08 07:53:14larrysetstatus: open -> closed
resolution: fixed
messages: + msg250168

stage: needs patch -> resolved
2015-03-09 19:31:30georg.brandlsetmessages: + msg237698
2015-03-09 09:23:27larrysetmessages: + msg237618
2015-02-09 17:51:30larrysetfiles: + larry.add-to-pydotorg.exe.support.1.diff
keywords: + patch
messages: + msg235624
2015-02-09 06:30:10georg.brandlsetmessages: + msg235593
2015-02-08 22:41:20larrysetmessages: + msg235573
2015-02-08 22:13:04larrycreate