➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2015-01-20 06:07 by zach.ware, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| binascii_clinic_fix.diff | zach.ware, 2015-01-20 06:07 | review | ||
| Messages (4) | |||
|---|---|---|---|
| msg234353 - (view) | Author: Zachary Ware (zach.ware) *  |
Date: 2015-01-20 06:07 | |
The Argument Clinic conversion of the binascii module left hexlify and unhexlify with bad docstrings:
hexlify(...)
b2a_hex($module, data, /)
--
Hexadecimal representation of binary data.
The return value is a bytes object. This function is also
available as "hexlify()".
unhexlify(...)
a2b_hex($module, hexstr, /)
--
Binary data of hexadecimal representation.
hexstr must contain an even number of hex digits (upper or lower case).
This function is also available as "unhexlify()".
Attached patch fixes it, removes the note that the function is also available as itself (leaving the note on {a2b,b2a}_hex), and tests that the functions are in fact aliases.
|
|||
| msg234358 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2015-01-20 07:46 | |
LGTM. |
|||
| msg234387 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2015-01-20 20:12 | |
New changeset 1cb2b46c5109 by Zachary Ware in branch '3.4': Issue #23280: Fix docstrings for binascii.(un)hexlify https://hg.python.org/cpython/rev/1cb2b46c5109 New changeset 754c630c98a3 by Zachary Ware in branch 'default': Merge with 3.4 (closes #23280) https://hg.python.org/cpython/rev/754c630c98a3 |
|||
| msg234388 - (view) | Author: Zachary Ware (zach.ware) * |
Date: 2015-01-20 20:14 | |
Thanks for the (very quick!) review, Serhiy. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:12 | admin | set | github: 67469 |
| 2015-01-20 20:14:44 | zach.ware | set | assignee: zach.ware messages: + msg234388 |
| 2015-01-20 20:12:40 | python-dev | set | status: open -> closed nosy: + python-dev messages: + msg234387 resolution: fixed stage: commit review -> resolved |
| 2015-01-20 07:46:23 | serhiy.storchaka | set | messages:
+ msg234358 stage: patch review -> commit review |
| 2015-01-20 06:07:31 | zach.ware | create | |