$ touch a
c: stat("a/x", ...) -> errno=ENOTDIR
$ python
>>> pathlib.Path('a/x').exists()

This should return False and not throw an exception.

Patch not tested.

Tested and works.

os.path.exists() ignores *all* OSErrors from stat.  This is probably too broad, but only ignoring ENOENT is probably too narrow.

ENAMETOOLONG and possibly ELOOP should also return False.
EACCES, EOVERFLOW and ENOMEM should probably be forwarded.
EFAULT should not happen.

ENAMETOOLONG: that doesn't mean the file doesn't exist. For example, it could be accessed by changing the current directory and shortening the residual path name.

ELOOP: unfortunately it doesn't guarantee that there is a real symlink loop, just that the OS decided to bail out after a certain number of indirections.

So in both cases I think we should let the errors bubble up.

Here is a patch with tests.

Should I file bugs for is_dir, is_file, is_symlink, is_socket, is_fifo, is_block_device and is_char_device?

Le 30/10/2014 20:36, Hristo Venev a écrit :
> 
> Hristo Venev added the comment:
> 
> Should I file bugs for is_dir, is_file, is_symlink, is_socket, is_fifo, is_block_device and is_char_device?

Hmm... good catch. No, this issue will do.

Updated patch for other querying function.

New changeset 40497cc445f4 by Antoine Pitrou in branch '3.4':
Issue #22759: Query methods on pathlib.Path() (exists(), is_dir(), etc.) now return False when the underlying stat call raises NotADirectoryError.
https://hg.python.org/cpython/rev/40497cc445f4

New changeset ff5f5fd230d3 by Antoine Pitrou in branch 'default':
Issue #22759: Query methods on pathlib.Path() (exists(), is_dir(), etc.) now return False when the underlying stat call raises NotADirectoryError.
https://hg.python.org/cpython/rev/ff5f5fd230d3

This is now fixed. Thanks for the report!