This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Idle configDialog: fix regression and add minimal unittest
Type: crash Stage: resolved
Components: IDLE Versions: Python 3.4, Python 3.5, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: terry.reedy Nosy List: Saimadhav.Heblikar, python-dev, terry.reedy
Priority: normal Keywords:

Created on 2014-07-14 14:43 by Saimadhav.Heblikar, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Messages (3)
msg223031 - (view) Author: Saimadhav Heblikar (Saimadhav.Heblikar) * Date: 2014-07-14 14:43
The concerned part : http://hg.python.org/cpython/rev/b836a0cd68f7#l4.15

"NameError: name 'keySet' is not defined."
msg223079 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-07-15 03:08
New changeset af1351800c7a by Terry Jan Reedy in branch '2.7':
Issue #21982: Add minimal unittest for configDialog with 46% coverage.
http://hg.python.org/cpython/rev/af1351800c7a

New changeset 681979c6e6b2 by Terry Jan Reedy in branch '3.4':
Issue #21982: Add minimal unittest for configDialog with 46% coverage.
http://hg.python.org/cpython/rev/681979c6e6b2
msg223081 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2014-07-15 03:20
Thanks for catching this. Either I misread pyflakes output or it has a bug. In either case, I should have searched this one like I did some others.  The htest caught this. I added a minimal unittest that initially failed, covers half the module, and now passes.

2.7 did not have the error, but the rest of the changes apply.

---
More info on a recurring 'nuisance': Start Idle on Windows from debug build interpreter. After ConfigDialog(), test termination causes the following to be printed in the interpreter window.

can't invoke "event" command: application has been destroyed
    while executing
"event generate $w <<ThemeChanged>>"
    (procedure "ttk::ThemeChanged" line 6)
    invoked from within
"ttk::ThemeChanged"

This happens *after* tearDownClass runs. I determined this by adding
def tearDownModule(): input('mod') to pause. Changing to "d = ConfigDialog(...); d.destroy()" has no effect. Commenting out parts of dialog construction might narrow down the responsible component.
History
Date User Action Args
2022-04-11 14:58:05adminsetgithub: 66181
2019-03-23 20:05:59terry.reedysetassignee: terry.reedy
components: + IDLE
2014-07-15 03:20:39terry.reedysetstatus: open -> closed
versions: + Python 2.7, Python 3.5
title: Idle: Regression introduced in configDialog by rev 91509 -> Idle configDialog: fix regression and add minimal unittest
messages: + msg223081

resolution: fixed
stage: resolved
2014-07-15 03:08:33python-devsetnosy: + python-dev
messages: + msg223079
2014-07-14 14:43:57Saimadhav.Heblikarsettype: crash
2014-07-14 14:43:31Saimadhav.Heblikarcreate