classification
Title: Fix test_ssl.py to handle LibreSSL versioning appropriately
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.5, Python 3.4, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: christian.heimes, dstufft, giampaolo.rodola, pitrou, python-dev, worr
Priority: normal Keywords: patch

Created on 2014-07-14 06:15 by worr, last changed 2014-07-21 22:41 by pitrou. This issue is now closed.

Files
File name Uploaded Description Edit
libressl-tests.diff worr, 2014-07-14 06:15 review
Messages (5)
msg222996 - (view) Author: William Orr (worr) * Date: 2014-07-14 06:15
Currently, test_ssl.py requires the version information to match the OpenSSL format exactly, and to be less than 2.0. LibreSSL, a drop-in replacement for OpenSSL, has started its version numbers at 2.0.0, and reports it slightly differently. This patch addresses that.

Tested on Exherbo Linux amd64 with LibreSSL portable 2.0.1.
msg223067 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2014-07-14 23:51
I don't have LibreSSL to test but the patch sounds fine to me.
msg223614 - (view) Author: Roundup Robot (python-dev) Date: 2014-07-21 22:37
New changeset 4dac45f88d45 by Antoine Pitrou in branch '3.4':
Issue #21976: Fix test_ssl to accept LibreSSL version strings.
http://hg.python.org/cpython/rev/4dac45f88d45

New changeset 98aec1d9e2a0 by Antoine Pitrou in branch 'default':
Issue #21976: Fix test_ssl to accept LibreSSL version strings.
http://hg.python.org/cpython/rev/98aec1d9e2a0
msg223615 - (view) Author: Roundup Robot (python-dev) Date: 2014-07-21 22:40
New changeset 33fc081285b2 by Antoine Pitrou in branch '2.7':
Issue #21976: Fix test_ssl to accept LibreSSL version strings.
http://hg.python.org/cpython/rev/33fc081285b2
msg223616 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2014-07-21 22:41
This should be fixed now. Thank you very much!
History
Date User Action Args
2014-07-21 22:41:03pitrousetstatus: open -> closed
resolution: fixed
messages: + msg223616

stage: patch review -> resolved
2014-07-21 22:40:32python-devsetmessages: + msg223615
2014-07-21 22:37:49python-devsetnosy: + python-dev
messages: + msg223614
2014-07-14 23:51:01pitrousetmessages: + msg223067
2014-07-14 19:31:58pitrousetstage: patch review
2014-07-14 15:21:16berker.peksagsetnosy: + pitrou, giampaolo.rodola, christian.heimes, dstufft

versions: - Python 3.1, Python 3.2, Python 3.3
2014-07-14 06:15:58worrcreate