This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Wrong test in ctypes
Type: behavior Stage: resolved
Components: ctypes, Tests Versions: Python 3.4, Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: zach.ware Nosy List: Claudiu.Popa, python-dev, r.david.murray, zach.ware
Priority: normal Keywords: patch

Created on 2014-06-23 12:52 by Claudiu.Popa, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
ctypes.patch Claudiu.Popa, 2014-06-23 12:52 review
Messages (4)
msg221351 - (view) Author: PCManticore (Claudiu.Popa) * (Python triager) Date: 2014-06-23 12:52
There's a problem with ctypes.test.test_values on Windows.
First, the test is wrong because it uses the following:

if __debug__:
    self.assertEqual(opt, 0)
elif ValuesTestCase.__doc__ is not None:
    self.assertEqual(opt, 1)

ValuesTestCase doesn't have a docstring and the check always fails when running the test suite with -O or -OO.
Second, running the test suite with -O and afterwards with -OO, will lead to the following failure:

======================================================================
FAIL: test_optimizeflag (ctypes.test.test_values.Win_ValuesTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\Projects\cpython\lib\ctypes\test\test_values.py", line 50, in test_optimizeflag
    self.assertEqual(opt, 1)
AssertionError: 2 != 1

----------------------------------------------------------------------

That's because the .pyo file for test_values already exist when rerunning with -OO and the docstring will be there. Now, I don't know why the file is not rebuilt and the documentation regarding -OO and -O is pretty scarce. The attached file tries a different approach, regenerate a test class each time the test is run in order to obtain its docstring. If run with -OO, it will be dropped properly.
msg221357 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2014-06-23 14:13
There is an issue open for the -O/-OO and .pyo file issue.  Or maybe we closed it won't fix, I forget.  -O/-OO have problems.
msg221641 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-06-26 20:22
New changeset ab708e4131dd by Zachary Ware in branch '3.4':
Issue #21829: Fix running test_ctypes on Windows with -O or -OO
http://hg.python.org/cpython/rev/ab708e4131dd

New changeset bbb28082d7b4 by Zachary Ware in branch 'default':
Issue #21829: Merge with 3.4
http://hg.python.org/cpython/rev/bbb28082d7b4
msg221643 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2014-06-26 20:25
Thanks for the report, Claudiu.  I went with a simpler fix, just comparing Py_OptimizeFlag with sys.flags.optimize.  That way, we don't care if we're running as -O, -OO, or -OOO, the test will always test against the correct value.
History
Date User Action Args
2022-04-11 14:58:05adminsetgithub: 66028
2014-06-26 20:25:01zach.waresetstatus: open -> closed
versions: + Python 3.4
messages: + msg221643

assignee: zach.ware
resolution: fixed
stage: patch review -> resolved
2014-06-26 20:22:34python-devsetnosy: + python-dev
messages: + msg221641
2014-06-23 14:13:00r.david.murraysetnosy: + r.david.murray
messages: + msg221357
2014-06-23 12:54:35Claudiu.Popasetnosy: + zach.ware
2014-06-23 12:52:05Claudiu.Popacreate