This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Fix a NameError in test_enum
Type: behavior Stage: patch review
Components: Tests Versions: Python 3.4, Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: ethan.furman Nosy List: Claudiu.Popa, ethan.furman, python-dev, vstinner
Priority: normal Keywords: patch

Created on 2014-06-15 20:09 by Claudiu.Popa, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
test_enum.patch Claudiu.Popa, 2014-06-15 20:09 review
Messages (4)
msg220669 - (view) Author: PCManticore (Claudiu.Popa) * (Python triager) Date: 2014-06-15 20:09
There's a bug in test_enum.TestStdLib.test_pydoc, print_diffs is undefined and using assertEqual seems to be clearer.
msg220745 - (view) Author: Ethan Furman (ethan.furman) * (Python committer) Date: 2014-06-16 18:33
Right, I had copied that code from test_pydoc which is where 'print_diffs' is defined.

A comment there says to use the now-included functionality in unittest, and some digging in the docs revealed that assertEqual uses diffs by default.
msg220760 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-06-16 20:51
New changeset 1536085d4a94 by Victor Stinner in branch '3.4':
Issue #21773: Fix TestStdLib.test_pydoc() of test_enum. Patch written by
http://hg.python.org/cpython/rev/1536085d4a94

New changeset e82ba67d7472 by Victor Stinner in branch 'default':
(Merge 3.4) Issue #21773: Fix TestStdLib.test_pydoc() of test_enum. Patch
http://hg.python.org/cpython/rev/e82ba67d7472
msg220761 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2014-06-16 20:52
Fixed. Thanks for the patch.
History
Date User Action Args
2022-04-11 14:58:04adminsetgithub: 65972
2014-06-16 20:52:29vstinnersetstatus: open -> closed
versions: + Python 3.4
nosy: + vstinner

messages: + msg220761

resolution: fixed
2014-06-16 20:51:53python-devsetnosy: + python-dev
messages: + msg220760
2014-06-16 18:33:01ethan.furmansetassignee: ethan.furman
type: enhancement -> behavior
messages: + msg220745
stage: patch review
2014-06-15 20:09:13Claudiu.Popacreate