Created on 2014-06-12 07:24 by Claudiu.Popa, last changed 2014-06-25 17:49 by serhiy.storchaka. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| dbm_with_open.patch | Claudiu.Popa, 2014-06-12 07:24 | review | ||
| Messages (5) | |||
|---|---|---|---|
| msg220335 - (view) | Author: Claudiu Popa (Claudiu.Popa) * | Date: 2014-06-12 07:24 | |
Hello. Here's a short patch for dbm.dumb, which uses in various places the `with` statement for opening and closing files. Thanks. |
|||
| msg220379 - (view) | Author: Raymond Hettinger (rhettinger) *  |
Date: 2014-06-12 20:07 | |
Serhiy, after reviewing this, consider backporting it. The original code doesn't have a try/finally around the close() call and that could be considered a bug. |
|||
| msg221559 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2014-06-25 17:06 | |
Ah, month ago I wrote large patch which use 'with' in various places in stdlib for opening and closing files. But then I dropped it because afraid that it can be considered as code churn. |
|||
| msg221561 - (view) | Author: Roundup Robot (python-dev) | Date: 2014-06-25 17:40 | |
New changeset fdbcb11e0323 by Serhiy Storchaka in branch '3.4': Issue #21729: Used the "with" statement in the dbm.dumb module to ensure http://hg.python.org/cpython/rev/fdbcb11e0323 New changeset e41b4e8c0c1d by Serhiy Storchaka in branch 'default': Issue #21729: Used the "with" statement in the dbm.dumb module to ensure http://hg.python.org/cpython/rev/e41b4e8c0c1d New changeset 893e79196fb3 by Serhiy Storchaka in branch '2.7': Issue #21729: Used the "with" statement in the dbm.dumb module to ensure http://hg.python.org/cpython/rev/893e79196fb3 |
|||
| msg221563 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2014-06-25 17:49 | |
Thanks Claudiu. Committed with yet one "with". |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2014-06-25 17:49:51 | serhiy.storchaka | set | status: open -> closed resolution: fixed messages: + msg221563 stage: commit review -> resolved |
| 2014-06-25 17:40:12 | python-dev | set | nosy:
+ python-dev messages: + msg221561 |
| 2014-06-25 17:06:10 | serhiy.storchaka | set | stage: patch review -> commit review messages: + msg221559 versions: + Python 2.7, Python 3.4 |
| 2014-06-12 20:07:33 | rhettinger | set | nosy:
+ rhettinger messages: + msg220379 |
| 2014-06-12 08:11:25 | serhiy.storchaka | set | priority: normal -> low assignee: serhiy.storchaka stage: patch review |
| 2014-06-12 07:24:41 | Claudiu.Popa | create | |