classification
Title: test_importlib incorrectly relies on .__builtins__
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.5, Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: eric.snow Nosy List: brett.cannon, eric.snow, python-dev
Priority: normal Keywords:

Created on 2014-05-13 18:13 by eric.snow, last changed 2014-05-13 18:20 by eric.snow. This issue is now closed.

Messages (2)
msg218474 - (view) Author: Eric Snow (eric.snow) * (Python committer) Date: 2014-05-13 18:13
Per the docs*, a module's __builtins__ may be a module or a dict or even missing.  However, test.test_importlib.test_api.ReloadTests checks __builtins__ as part of several tests.  Instead, the tests should ignore __bulitins__.  I'll push a patch in a minute that fixes that.

* https://docs.python.org/3/library/builtins.html
msg218475 - (view) Author: Roundup Robot (python-dev) Date: 2014-05-13 18:19
New changeset 16d26391ec36 by Eric Snow in branch '3.4':
Issue #21499: Ignore __builtins__ in several test_importlib.test_api tests.
http://hg.python.org/cpython/rev/16d26391ec36

New changeset bdf94b2c0639 by Eric Snow in branch 'default':
Merge from 3.4 (for #21499).
http://hg.python.org/cpython/rev/bdf94b2c0639
History
Date User Action Args
2014-05-13 18:20:25eric.snowsetstatus: open -> closed
resolution: fixed
stage: needs patch -> resolved
2014-05-13 18:19:47python-devsetnosy: + python-dev
messages: + msg218475
2014-05-13 18:13:54eric.snowcreate