➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2014-05-05 17:22 by tim.golden, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| issue21440.test_zipfile.patch | tim.golden, 2014-05-05 17:23 | review | ||
| issue21440.test_tarzipfile.patch | tim.golden, 2014-05-05 17:34 | review | ||
| Messages (7) | |||
|---|---|---|---|
| msg217935 - (view) | Author: Tim Golden (tim.golden) *  |
Date: 2014-05-05 17:22 | |
At present test_zipfile uses shutil.rmtree to remove its test artefacts. This intermittently but frequently fails to remove cleanly on a Windows development box. Changing it to use the test.support helper functions should reduce the incidence. |
|||
| msg217937 - (view) | Author: Tim Golden (tim.golden) * |
Date: 2014-05-05 17:34 | |
Same goes for test_tarfile (updated patch attached) |
|||
| msg217938 - (view) | Author: Tim Golden (tim.golden) * |
Date: 2014-05-05 17:35 | |
Adding Zach as another Windows dev |
|||
| msg217945 - (view) | Author: Zachary Ware (zach.ware) * |
Date: 2014-05-05 19:32 | |
I don't see the intermittent failures (this machine may well just be too slow). The patch looks good and doesn't cause failures, though, so +1 from me. |
|||
| msg217946 - (view) | Author: Tim Golden (tim.golden) * |
Date: 2014-05-05 19:33 | |
Thanks. I get them enough that it stops a test run being particularly useful, especially when I've just touched something (eg unlink) which might conceivably affect something like tarfile. |
|||
| msg217977 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2014-05-06 12:28 | |
New changeset 4ebf97299b18 by Tim Golden in branch 'default': Issue21440 Use support.rmtree in test_zipfile & test_tarfile http://hg.python.org/cpython/rev/4ebf97299b18 |
|||
| msg226333 - (view) | Author: Roundup Robot (python-dev) |
Date: 2014-09-03 22:54 | |
New changeset 706ec07100d6 by Victor Stinner in branch '3.4': Issue #21440: Backport changeset 4ebf97299b18 to branch 3.4, use http://hg.python.org/cpython/rev/706ec07100d6 New changeset 6b4d31641109 by Victor Stinner in branch '3.4': Issue #21440: test_zipfile: replace last direct calls to os.remove() with http://hg.python.org/cpython/rev/6b4d31641109 New changeset 73ce1afc6ee2 by Victor Stinner in branch 'default': (Merge 3.4) Issue #21440: test_zipfile: replace last direct calls to http://hg.python.org/cpython/rev/73ce1afc6ee2 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:03 | admin | set | github: 65639 |
| 2014-09-03 22:54:01 | python-dev | set | messages: + msg226333 |
| 2014-05-06 13:30:15 | tim.golden | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2014-05-06 12:28:42 | python-dev | set | nosy:
+ python-dev messages: + msg217977 |
| 2014-05-05 19:33:33 | tim.golden | set | messages: + msg217946 |
| 2014-05-05 19:32:21 | zach.ware | set | messages: + msg217945 |
| 2014-05-05 17:35:22 | tim.golden | set | nosy:
+ zach.ware messages: + msg217938 |
| 2014-05-05 17:34:57 | tim.golden | set | files:
+ issue21440.test_tarzipfile.patch messages: + msg217937 |
| 2014-05-05 17:23:39 | tim.golden | set | files:
+ issue21440.test_zipfile.patch keywords: + patch |
| 2014-05-05 17:22:10 | tim.golden | create | |