This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: mark test_devpoll to be meaningful only for Solaris
Type: Stage: resolved
Components: Tests Versions: Python 3.4, Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: jcea Nosy List: AapoRantalainen, jcea, python-dev, r.david.murray
Priority: normal Keywords:

Created on 2014-04-20 18:36 by AapoRantalainen, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Messages (4)
msg216913 - (view) Author: Aapo Rantalainen (AapoRantalainen) Date: 2014-04-20 18:36
[ 96/389/2] test_devpoll
Actual happened:
 test_devpoll skipped -- select.devpoll not defined
Excepted:
 test works only on Solaris


Took me a while until I read documentation: 
 select.devpoll()
  ->     (Only supported on Solaris and derivatives.)

Even test itself, test_devpoll.py, doesn't mention it is only for Solaris.
msg217526 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-04-29 16:19
New changeset cc2345e6e9ff by Jesus Cea in branch '3.4':
Closes issue #21316: mark test_devpoll to be meaningfull only for Solaris
http://hg.python.org/cpython/rev/cc2345e6e9ff

New changeset 825c67196aac by Jesus Cea in branch 'default':
MERGE: Closes issue #21316: mark test_devpoll to be meaningfull only for Solaris
http://hg.python.org/cpython/rev/825c67196aac
msg217527 - (view) Author: Jesús Cea Avión (jcea) * (Python committer) Date: 2014-04-29 16:21
Thanks for the head-up!!. Can you compile new version and try it out?.
msg217954 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2014-05-05 20:44
There's no pressing reason to revisit this, but...I think it would be better to say "works only on systems that support devpoll (ie: Solaris and derivatives)"  Also, as long as you are changing the try/except, you could use skipUnless(hasattr(select, 'devpoll'), ...) instead of an if.
History
Date User Action Args
2022-04-11 14:58:02adminsetgithub: 65515
2014-05-05 20:44:33r.david.murraysetnosy: + r.david.murray
messages: + msg217954
2014-04-29 16:21:13jceasetmessages: + msg217527
2014-04-29 16:20:09jceasetstatus: open -> closed
type: enhancement ->
resolution: fixed
stage: resolved
2014-04-29 16:19:14python-devsetnosy: + python-dev
messages: + msg217526
2014-04-29 16:17:16jceasetassignee: jcea
title: mark test_devpoll to be meaningfull only for Solaris -> mark test_devpoll to be meaningful only for Solaris

nosy: + jcea
versions: + Python 3.5
2014-04-20 18:36:52AapoRantalainencreate