This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: make.bat not building documentation
Type: behavior Stage: resolved
Components: Documentation Versions: Python 3.4, Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: zach.ware Nosy List: docs@python, dsawyer, python-dev, zach.ware
Priority: normal Keywords: patch

Created on 2014-04-17 20:14 by dsawyer, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
mywork.patch dsawyer, 2014-04-17 20:53 review
mywork.patch dsawyer, 2014-04-17 23:35 review
Messages (8)
msg216737 - (view) Author: Dave Sawyer (dsawyer) * Date: 2014-04-17 20:14
With Python 3.5, some refactoring of the documentation structure has been done. Building the documentation targets directly works, but using the supplied make.bat fails, not finding the sphinx python file.
msg216739 - (view) Author: Dave Sawyer (dsawyer) * Date: 2014-04-17 20:55
Removed the use of python in the make, calling the sphinx-build executable. Also the Doc directory was called "Docs" in the readme.txt
msg216744 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2014-04-17 21:09
I left a review on Rietveld, which should have sent you an email.

Thanks for the report and patch!  If you plan on submitting anything more than the most trivial of patches, could you please sign the contributor agreement[1][2]?  Thanks!


[1]The form: https://www.python.org/psf/contrib/contrib-form/
[2]More information: https://www.python.org/psf/contrib/
msg216765 - (view) Author: Dave Sawyer (dsawyer) * Date: 2014-04-17 23:37
Thanks Zach! The bug tracker was nice enough to prompt me to go look in my email for the agreement too.
msg216788 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2014-04-18 16:41
Your more recent patch looks like it's missing the changes to Doc/make.bat, which I assume was unintentional :).  Also, thinking about it again, it would be good to use a %SPHINXBUILD% variable rather than hard-coding "sphinx-build" into the script, the same way %PYTHON% is used currently.
msg216802 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-04-18 20:45
New changeset 02fec733f760 by Zachary Ware in branch '3.4':
Issue #21289: Fix documentation building on Windows using Doc/make.bat.
http://hg.python.org/cpython/rev/02fec733f760
msg216803 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2014-04-18 20:48
Fixed, thanks for the patch!  I went ahead and implemented my comments and committed it.
msg216807 - (view) Author: Dave Sawyer (dsawyer) * Date: 2014-04-18 21:35
Thanks Zach, I'm used to Git and this was my first foray with Hg and trying
to rebase (I knew I shoulda branched before starting on another patch). BTW,
the devs at PyCon Montreal said "Zach's a good guy. One of maybe 4 Windows
devs."

-Dave
History
Date User Action Args
2022-04-11 14:58:02adminsetgithub: 65488
2014-04-18 21:35:12dsawyersetmessages: + msg216807
2014-04-18 20:48:13zach.waresetstatus: open -> closed
resolution: fixed
messages: + msg216803

stage: patch review -> resolved
2014-04-18 20:45:47python-devsetnosy: + python-dev
messages: + msg216802
2014-04-18 16:41:17zach.waresetmessages: + msg216788
2014-04-17 23:37:36dsawyersetmessages: + msg216765
2014-04-17 23:35:51dsawyersetfiles: + mywork.patch
2014-04-17 21:09:59zach.waresetversions: + Python 3.4
nosy: + zach.ware

messages: + msg216744

assignee: docs@python -> zach.ware
stage: patch review
2014-04-17 20:55:12dsawyersetmessages: + msg216739
2014-04-17 20:53:45dsawyersetfiles: + mywork.patch
keywords: + patch
2014-04-17 20:15:48dsawyersettype: compile error -> behavior
2014-04-17 20:14:03dsawyercreate