classification
Title: refactor and fix curses configure checks
Type: Stage:
Components: Build Versions: Python 3.5, Python 3.4, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: doko, haypo, python-dev, twouters
Priority: normal Keywords: patch

Created on 2014-04-17 16:04 by doko, last changed 2014-04-17 20:12 by doko. This issue is now closed.

Files
File name Uploaded Description Edit
ncurses-configure.diff doko, 2014-04-17 16:04
Messages (5)
msg216704 - (view) Author: Matthias Klose (doko) * (Python committer) Date: 2014-04-17 16:04
this refactors the curses configure checks, and fixes the build with ncursesw.  In it's current form the curses feature checks are run without the additional include path which leads to wrong results if the only the nurses headers are installed.
msg216719 - (view) Author: Thomas Wouters (twouters) * (Python committer) Date: 2014-04-17 17:49
Good fix. Do remove the 'first curses header check' comment you add, and don't forget to regenerate configure (and maybe pyconfig.h.in? I don't know if that'll change.)
msg216721 - (view) Author: Roundup Robot (python-dev) Date: 2014-04-17 18:14
New changeset 1bc0a8310b9f by doko in branch '2.7':
- Issue #21285: Refactor and fix curses configure check to always search
http://hg.python.org/cpython/rev/1bc0a8310b9f

New changeset 635817da596d by doko in branch '3.4':
- Issue #21285: Refactor and fix curses configure check to always search
http://hg.python.org/cpython/rev/635817da596d
msg216722 - (view) Author: Matthias Klose (doko) * (Python committer) Date: 2014-04-17 18:22
looks like with this change the curses extension isn't built anymore on Solaris.
msg216736 - (view) Author: Matthias Klose (doko) * (Python committer) Date: 2014-04-17 20:12
Victor pointer out the Solaris issue is unrelated. See #13552. Closing.
History
Date User Action Args
2014-04-17 20:12:21dokosetstatus: open -> closed
resolution: fixed
messages: + msg216736
2014-04-17 18:22:56dokosettitle: refactor anfd fix curses configure checks -> refactor and fix curses configure checks
2014-04-17 18:22:20dokosetnosy: + haypo
messages: + msg216722
2014-04-17 18:14:41python-devsetnosy: + python-dev
messages: + msg216721
2014-04-17 17:49:51twouterssetmessages: + msg216719
2014-04-17 16:04:41dokosetnosy: + twouters
2014-04-17 16:04:31dokosetversions: + Python 2.7
2014-04-17 16:04:16dokocreate