➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2014-03-18 20:54 by OrangeTux, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| 0001-Issue-20973-Add-total-ordering-unit-tests-for-ipaddr.patch | tbeadle, 2016-06-02 19:05 | Add total ordering unit tests for ipaddress module | ||
| Messages (4) | |||
|---|---|---|---|
| msg214017 - (view) | Author: Auke Willem Oosterhoff (OrangeTux) * | Date: 2014-03-18 20:54 | |
The comparison methods of _TotalOrderingMixin don't have nice implementation. Some of them raises a NotImplementedError. A few aren't covered in the tests. The comment suggests that these methods has been implemented this way because of issue 10042 which has been fixed. [1]:http://hg.python.org/cpython/file/f8b40d33e45d/Lib/ipaddress.py#l396 [2]:http://bugs.python.org/issue10042 |
|||
| msg214036 - (view) | Author: R. David Murray (r.david.murray) *  |
Date: 2014-03-18 23:03 | |
The two that raise are the two that are required on the concrete class in order for the mixin to work. Not having tests is certainly an issue worth correcting. |
|||
| msg266936 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2016-06-02 19:50 | |
New changeset ffaefb20dd06 by R David Murray in branch '3.5': #20973: add total ordering tests for ipaddress https://hg.python.org/cpython/rev/ffaefb20dd06 New changeset 503168ec3d4f by R David Murray in branch 'default': Merge: #20973: add total ordering tests for ipaddress https://hg.python.org/cpython/rev/503168ec3d4f |
|||
| msg266937 - (view) | Author: R. David Murray (r.david.murray) * |
Date: 2016-06-02 19:51 | |
Thanks, Tommy. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:00 | admin | set | github: 65172 |
| 2016-06-02 19:51:28 | r.david.murray | set | status: open -> closed versions: + Python 3.6 messages: + msg266937 resolution: fixed stage: resolved |
| 2016-06-02 19:50:33 | python-dev | set | nosy:
+ python-dev messages: + msg266936 |
| 2016-06-02 19:05:25 | tbeadle | set | files:
+ 0001-Issue-20973-Add-total-ordering-unit-tests-for-ipaddr.patch keywords: + patch |
| 2014-03-18 23:03:29 | r.david.murray | set | nosy:
+ r.david.murray messages: + msg214036 |
| 2014-03-18 20:55:29 | OrangeTux | set | title: Implement proper comparison operations for in _TotalOrderingMixin in ipaddres module. -> Implement proper comparison operations for in _TotalOrderingMixin in ipaddress module. |
| 2014-03-18 20:54:29 | OrangeTux | create | |