➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2014-02-17 08:28 by vajrasky, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| add_subprocess_to_tests.patch | vajrasky, 2014-02-17 08:28 | review | ||
| permanent_fix_for_executing_test_asyncio_in_bundle.patch | vajrasky, 2014-02-17 08:30 | review | ||
| Messages (7) | |||
|---|---|---|---|
| msg211398 - (view) | Author: Vajrasky Kok (vajrasky) * | Date: 2014-02-17 08:28 | |
ethan@amiau:~/Documents/code/python/cpython3.4$ cat Lib/test/test_asyncio/tests.txt test_asyncio.test_base_events test_asyncio.test_events test_asyncio.test_futures test_asyncio.test_locks test_asyncio.test_proactor_events test_asyncio.test_queues test_asyncio.test_selector_events test_asyncio.test_streams test_asyncio.test_tasks test_asyncio.test_transports test_asyncio.test_unix_events test_asyncio.test_windows_events test_asyncio.test_windows_utils ethan@amiau:~/Documents/code/python/cpython3.4$ ls Lib/test/test_asyncio/test_subprocess.py Lib/test/test_asyncio/test_subprocess.py I provide two alternatives to fix this problem. The first is to add subprocess in tests.txt. |
|||
| msg211399 - (view) | Author: Vajrasky Kok (vajrasky) * | Date: 2014-02-17 08:30 | |
The second is the permanent fix so we don't need to add new test to tests.txt every time we want to add new test to asyncio test bundle. |
|||
| msg211402 - (view) | Author: STINNER Victor (vstinner) *  |
Date: 2014-02-17 09:44 | |
I prefer to dynamically discover tests, as we do in all other Python tests. I don't like hardcoded list, it leads to such issue. @Guido: What do you think? |
|||
| msg211429 - (view) | Author: Guido van Rossum (gvanrossum) * |
Date: 2014-02-17 17:19 | |
Please apply the fix and make sure it gets cherry-picked. I agree on dynamic test recovery but don't find it a high priority. |
|||
| msg211454 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2014-02-17 23:12 | |
New changeset b3987d758e49 by Victor Stinner in branch 'default': Issue #20655: Fix test_asyncio, run also subprocess tests. Patch written by http://hg.python.org/cpython/rev/b3987d758e49 |
|||
| msg211456 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2014-02-17 23:13 | |
Thanks Vajrasky for your fix. You may open a new issue for permanent_fix_for_executing_test_asyncio_in_bundle.patch. |
|||
| msg213802 - (view) | Author: Roundup Robot (python-dev) |
Date: 2014-03-17 06:30 | |
New changeset b22b83ea719d by Victor Stinner in branch '3.4': Issue #20655: Fix test_asyncio, run also subprocess tests. Patch written by http://hg.python.org/cpython/rev/b22b83ea719d |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:58 | admin | set | github: 64854 |
| 2014-03-17 06:30:47 | python-dev | set | messages: + msg213802 |
| 2014-02-17 23:13:11 | vstinner | set | status: open -> closed resolution: fixed messages: + msg211456 |
| 2014-02-17 23:12:05 | python-dev | set | nosy:
+ python-dev messages: + msg211454 |
| 2014-02-17 17:19:56 | gvanrossum | set | messages: + msg211429 |
| 2014-02-17 09:44:48 | vstinner | set | messages: + msg211402 |
| 2014-02-17 08:30:06 | vajrasky | set | files:
+ permanent_fix_for_executing_test_asyncio_in_bundle.patch messages: + msg211399 |
| 2014-02-17 08:28:15 | vajrasky | create | |