This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Missing invalid mode in error message of socket.makefile.
Type: behavior Stage: resolved
Components: Library (Lib) Versions: Python 3.4, Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: serhiy.storchaka Nosy List: franck, pitrou, python-dev, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2014-02-11 21:40 by franck, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
missing_mode_in_error.patch franck, 2014-02-11 21:40 review
Messages (3)
msg211026 - (view) Author: Franck Michea (franck) * Date: 2014-02-11 21:40
Hi! Noticed that the wrong mode was missing from the error message of socket.makefile. Nothing important, but this patch fixes the thing anyway, if you want it.
msg231366 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2014-11-19 10:29
Thank you for your patch Franck. But it would be more useful to output all mode argument, not only wrong character. And it should be wrapped in a tuple to prevent subtle formatting error.
msg231367 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-11-19 10:36
New changeset 34c7be03259b by Serhiy Storchaka in branch '3.4':
Issue #20604: Added missed invalid mode in error message of socket.makefile().
https://hg.python.org/cpython/rev/34c7be03259b

New changeset d5b36edeecdb by Serhiy Storchaka in branch 'default':
Issue #20604: Added missed invalid mode in error message of socket.makefile().
https://hg.python.org/cpython/rev/d5b36edeecdb
History
Date User Action Args
2022-04-11 14:57:58adminsetgithub: 64803
2014-11-19 10:47:25serhiy.storchakasetstatus: open -> closed
resolution: fixed
stage: resolved
2014-11-19 10:36:33python-devsetnosy: + python-dev
messages: + msg231367
2014-11-19 10:29:24serhiy.storchakasetassignee: serhiy.storchaka
type: enhancement -> behavior
2014-11-19 10:29:02serhiy.storchakasetnosy: + serhiy.storchaka

messages: + msg231366
versions: + Python 3.5, - Python 3.3
2014-02-12 12:57:42berker.peksagsetnosy: + pitrou

versions: - Python 3.5
2014-02-11 21:40:35franckcreate