classification
Title: Code generated by asdl_c.py not C89-compliant
Type: compile error Stage: resolved
Components: Interpreter Core Versions: Python 3.4, Python 3.3
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: Jeffrey.Armstrong, benjamin.peterson, python-dev
Priority: normal Keywords: patch

Created on 2014-02-11 01:33 by Jeffrey.Armstrong, last changed 2014-02-11 03:41 by python-dev. This issue is now closed.

Files
File name Uploaded Description Edit
asdl_c.py.trunk.patch Jeffrey.Armstrong, 2014-02-11 01:33 Minor change to asdl_c.py for C89 compliance review
Messages (2)
msg210894 - (view) Author: Jeffrey Armstrong (Jeffrey.Armstrong) * Date: 2014-02-11 01:33 
The code within Python/Python-ast.c does not currently conform to C89 standard.  Within the function PyAST_obj2mod(), the array 'req_type' is initialized using runtime values, which is not allowed by the standard, causing building to fail on a C89 compiler.

This code is automatically generated by asdl_c.py.  I've attached a patch which corrects the problem.  Python/Python-ast.c will need to be regenerated if this patch is accepted.
msg210898 - (view) Author: Roundup Robot (python-dev) Date: 2014-02-11 03:41 
New changeset 5b3bb4bda9cb by Benjamin Peterson in branch '3.3':
don't put runtime values in array initializer for C89 compliance (closes #20588)
http://hg.python.org/cpython/rev/5b3bb4bda9cb

New changeset cdaf7b38bb2c by Benjamin Peterson in branch 'default':
merge 3.3 (#20588)
http://hg.python.org/cpython/rev/cdaf7b38bb2c
History
Date User Action Args
2014-02-11 03:41:49python-devsetstatus: open -> closed

nosy: + python-dev
messages: + msg210898

resolution: fixed
stage: resolved
2014-02-11 01:45:20r.david.murraysetnosy: + benjamin.peterson
2014-02-11 01:33:12Jeffrey.Armstrongcreate