classification
Title: test_socket failures on OS X due to fixed "expected failures"
Type: Stage: resolved
Components: Tests Versions: Python 3.4, Python 3.3
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: ned.deily Nosy List: larry, ncoghlan, ned.deily, python-dev
Priority: high Keywords: patch

Created on 2014-02-01 10:11 by ned.deily, last changed 2014-02-03 22:04 by ned.deily. This issue is now closed.

Files
File name Uploaded Description Edit
issue20474.patch ned.deily, 2014-02-01 10:15 review
Messages (2)
msg209882 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2014-02-01 10:11
Three "send timeout" test cases in test_socket were changed by a4e4facad164 for Issue12958 to be "expected failures" on OS X because of observed failures on the OS X buildbots running OS X 10.6 (Snow Leopard) and earlier.

testInterruptedSendTimeout (test.test_socket.InterruptedSendTimeoutTest) ... unexpected success
testInterruptedSendmsgTimeout (test.test_socket.InterruptedSendTimeoutTest) ... unexpected success
testInterruptedSendtoTimeout (test.test_socket.InterruptedSendTimeoutTest) ... unexpected success

It seems that the platform bugs causing the failures were fixed in OS X 10.7 so that the "expected failures" no longer fail.  However, the change in behavior had not been noticed because, until the recent change to unittest in Issue20165, unittest did not fail when there were unexpected successes.  Now it does fail, causing test_socket to fail on OS X 10.7+ for 3.4.  On 3.3 the "unexpected success" failures are silently skipped.  The attached patch changes the test cases to be skipped for OS X versions prior to 10.7 rather than to always expect failure on OS X.
msg210167 - (view) Author: Roundup Robot (python-dev) Date: 2014-02-03 22:02
New changeset 63efacd80f8e by Ned Deily in branch '3.3':
Issue #20474: Fix "unexpected success" test_socket failures on OS X 10.7+.
http://hg.python.org/cpython/rev/63efacd80f8e

New changeset 036671354dc0 by Ned Deily in branch 'default':
Issue #20474: Fix "unexpected success" test_socket failures on OS X 10.7+.
http://hg.python.org/cpython/rev/036671354dc0
History
Date User Action Args
2014-02-03 22:04:13ned.deilysetstatus: open -> closed
assignee: ned.deily
resolution: fixed
stage: patch review -> resolved
2014-02-03 22:02:55python-devsetnosy: + python-dev
messages: + msg210167
2014-02-01 10:15:21ned.deilysetfiles: + issue20474.patch
2014-02-01 10:15:06ned.deilysetfiles: - issue20474.patch
2014-02-01 10:13:34ned.deilysetfiles: + issue20474.patch
keywords: + patch
2014-02-01 10:11:49ned.deilycreate