➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2014-01-30 15:22 by vstinner, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| overlapped.patch | vstinner, 2014-01-30 15:22 | review | ||
| Messages (2) | |||
|---|---|---|---|
| msg209721 - (view) | Author: STINNER Victor (vstinner) *  |
Date: 2014-01-30 15:22 | |
I found an issue in overlapped.c: read_buffer and write_buffer attributes are defined in an union, but they are sometimes use even if the type is not good. I found this issue while trying to get a BrokenPipeError on Windows when the stdin stream of a subprocess is full but the process exited. Could you please review attached patch, especially the change in Overlapped_getresult? Another option would be to use two real attributes (remove the union), but I like the usage of union :-) All Tulip unit tests of my subprocess_stream pass on Linux and Windows with the patch. |
|||
| msg209737 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2014-01-30 20:45 | |
Patch commited as 73dbb884eb09 in Python 3.4. (No need to backport, it's a new module in Python 3.4). Thanks for the review Richard. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:57 | admin | set | github: 64648 |
| 2014-01-30 20:45:43 | vstinner | set | status: open -> closed resolution: fixed messages: + msg209737 |
| 2014-01-30 15:22:29 | vstinner | create | |