classification
Title: Argument Clinic: backslashes in docstrings are not escaped
Type: behavior Stage: resolved
Components: Demos and Tools Versions: Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: zach.ware Nosy List: larry, python-dev, serhiy.storchaka, zach.ware
Priority: normal Keywords: patch

Created on 2014-01-24 08:21 by serhiy.storchaka, last changed 2014-01-25 09:27 by zach.ware. This issue is now closed.

Files
File name Uploaded Description Edit
issue20376.diff zach.ware, 2014-01-24 17:54 review
Messages (6)
msg209044 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2014-01-24 08:21
Argument Clinic copies backslashes in docstrings as is. This can produce wrong or even invalid C string. Either backslashes should be escaped, or current behavior should be documented.
msg209049 - (view) Author: Larry Hastings (larry) * (Python committer) Date: 2014-01-24 08:53
Oops!  They should be escaped.
msg209104 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2014-01-24 17:54
This should do it, correct?
msg209172 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2014-01-25 09:14
LGTM.
msg209174 - (view) Author: Roundup Robot (python-dev) Date: 2014-01-25 09:26
New changeset 381c9d592cc8 by Zachary Ware in branch 'default':
Issue #20376: Argument Clinic now escapes backslashes in docstrings.
http://hg.python.org/cpython/rev/381c9d592cc8
msg209175 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2014-01-25 09:27
Done!
History
Date User Action Args
2014-01-25 09:27:02zach.waresetstatus: open -> closed
resolution: fixed
messages: + msg209175

stage: commit review -> resolved
2014-01-25 09:26:33python-devsetnosy: + python-dev
messages: + msg209174
2014-01-25 09:14:10serhiy.storchakasetassignee: zach.ware
messages: + msg209172
stage: commit review
2014-01-25 09:01:38serhiy.storchakalinkissue20151 dependencies
2014-01-24 17:54:15zach.waresetfiles: + issue20376.diff

nosy: + zach.ware
messages: + msg209104

keywords: + patch
2014-01-24 08:53:39larrysetmessages: + msg209049
2014-01-24 08:21:59serhiy.storchakacreate