Title: do not add invalid header locations
Type: compile error Stage:
Components: Cross-Build Versions: Python 3.4
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: doko, haypo, hundeboll, thomas-petazzoni
Priority: normal Keywords: patch

Created on 2014-01-09 23:02 by thomas-petazzoni, last changed 2016-03-09 22:07 by BreamoreBoy.

File name Uploaded Description Edit thomas-petazzoni, 2014-01-09 23:02
Messages (3)
msg207805 - (view) Author: Thomas Petazzoni (thomas-petazzoni) Date: 2014-01-09 23:02
In the cross-compilation case, incorrectly adds /usr/include to self.compiler.include_dirs, and results in the following invalid compilation line:

  -fPIC -Wno-unused-result -Werror=declaration-after-statement -DNDEBUG -g
  -O3 -Wall -Wstrict-prototypes -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
  -D_FILE_OFFSET_BITS=64 -pipe -Os
  -I./Include -I/usr/include -I. -IInclude
  -c /home/thomas/projets/buildroot/output/build/python3-3.4.0b1/Modules/_struct.c
  -o build/temp.linux-arm-3.4/home/thomas/projets/buildroot/output/build/python3-3.4.0b1/Modules/_struct.o
cc1: warning: include location "/usr/include" is unsafe for cross-compilation [-Wpoison-system-directories]

The -I/usr/include is wrong when cross compiling, so we disable adding INCLUDEDIR and LIBDIR from the host when cross compiling.
msg237380 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2015-03-06 20:55
Can we have a patch review on this issue please.
msg261435 - (view) Author: Martin Hundebøll (hundeboll) Date: 2016-03-09 15:24
The patch looks good to me, and works in my setup.
Date User Action Args
2016-03-09 22:07:15BreamoreBoysetnosy: - BreamoreBoy
2016-03-09 15:24:27hundebollsetnosy: + hundeboll
messages: + msg261435
2016-03-09 15:22:33berker.peksaglinkissue26443 superseder
2015-03-06 20:55:09BreamoreBoysetnosy: + BreamoreBoy
messages: + msg237380
2014-02-17 23:07:36hayposetnosy: + doko, haypo
2014-01-09 23:02:08thomas-petazzonicreate